Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port changes from main into Stable to make the CI green #36665

Merged

Conversation

cipolleschi
Copy link
Contributor

Summary

This change ports to 0.72 stable some other changes we are landing in main in order to solve the issues with Metro and the CLI

Changelog

[Internal][Fixed] - Make Metro run properly on RNTester, exluding the integration tests

Test Plan

  • JS Tests on CircleCI should be green now

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 27, 2023
@cipolleschi cipolleschi force-pushed the cipolleschi/fix_disable_ios_integration_tests branch from c70961d to 8a1f167 Compare March 27, 2023 18:25
@cipolleschi cipolleschi changed the title Port [RN] Fix paths in objc-test.sh, temporarily exclude /IntegrationTests from main Port changes from main into Stable to make the CI green Mar 28, 2023
@cipolleschi cipolleschi force-pushed the cipolleschi/fix_disable_ios_integration_tests branch from 7929d67 to 3cf42cc Compare March 28, 2023 13:01
@github-actions
Copy link

github-actions bot commented Mar 28, 2023

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4d245cc

@cipolleschi cipolleschi force-pushed the cipolleschi/fix_disable_ios_integration_tests branch from 3cf42cc to 0db6355 Compare March 28, 2023 13:08
@analysis-bot
Copy link

analysis-bot commented Mar 28, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,539,304 +19,609
android hermes armeabi-v7a 7,854,901 +19,093
android hermes x86 9,019,156 +20,535
android hermes x86_64 8,874,224 +19,323
android jsc arm64-v8a 9,140,608 -253
android jsc armeabi-v7a 8,332,247 -753
android jsc x86 9,195,190 +643
android jsc x86_64 9,453,020 -620

Base commit: a83c192
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/fix_disable_ios_integration_tests branch 3 times, most recently from 63566d0 to 2104e77 Compare March 28, 2023 15:45
Summary:
Changelog:
[General][Added] - Add `react-native/metro-config` package

Pull Request resolved: #36502

## Context

### React Native Metro config → React Native repo (#36502)

We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package.

This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users.

**See full motivation, design, and test plan here: #36502

## Changes

- This PR adds the new `react-native/metro-config` package, reproduces all static values previously defined in RN CLI. The values which remain in RN CLI are dynamic values derived from CLI options passed by the user.

{F906910591}

Reviewed By: cortinico

Differential Revision: D44099692

fbshipit-source-id: 672a67e19d866ac2c64fc84983b5d82c604918c6
@cipolleschi cipolleschi force-pushed the cipolleschi/fix_disable_ios_integration_tests branch from 2104e77 to 4d245cc Compare March 28, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants