Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export EmitterSubscription TypeScript Type #36632

Closed
wants to merge 1 commit into from

Conversation

NickGerleman
Copy link
Contributor

Summary:
Discovered when bumping the RN documentation to typecheck against 0.72, #36109 removed the EmitterSubscription type which should be kept public.

Changelog:
[General][Fixed] - Export EmitterSubscription TypeScript Type

Differential Revision: D44375081

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44375081

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44375081

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Mar 24, 2023
Summary:
Pull Request resolved: facebook#36632

Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public.

Changelog:
[General][Fixed] -  Export EmitterSubscription TypeScript Type

Differential Revision: D44375081

fbshipit-source-id: 5b3f2343e8b3f224bfbc72b285f333afd45269bb
@analysis-bot
Copy link

analysis-bot commented Mar 24, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,620,787 +0
android hermes armeabi-v7a 7,933,466 +0
android hermes x86 9,106,793 +0
android hermes x86_64 8,961,595 +0
android jsc arm64-v8a 9,186,843 +0
android jsc armeabi-v7a 8,377,136 +0
android jsc x86 9,244,445 +0
android jsc x86_64 9,502,916 +0

Base commit: 72d2880
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44375081

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Mar 24, 2023
Summary:
Pull Request resolved: facebook#36632

Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public.

Changelog:
[General][Fixed] -  Export EmitterSubscription TypeScript Type

Differential Revision: D44375081

fbshipit-source-id: a75e4be326deedbeb06370860344f3c96b9a5426
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44375081

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 17, 2023
Summary:
Pull Request resolved: facebook#36632

Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public.

Changelog:
[General][Fixed] -  Export EmitterSubscription TypeScript Type

Reviewed By: cortinico

Differential Revision: D44375081

fbshipit-source-id: 74e1299749da9fb920742664a0ecccd871190947
Summary:
Pull Request resolved: facebook#36632

Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public.

Changelog:
[General][Fixed] -  Export EmitterSubscription TypeScript Type

Reviewed By: cortinico

Differential Revision: D44375081

fbshipit-source-id: 4f5e2b36a42c5917cea37a6f0cd0b53420cf6b27
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44375081

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in eb83356.

kelset pushed a commit that referenced this pull request May 3, 2023
Summary:
Pull Request resolved: #36632

Discovered when bumping the RN documentation to typecheck against 0.72, #36109 removed the `EmitterSubscription` type which should be kept public.

Changelog:
[General][Fixed] -  Export EmitterSubscription TypeScript Type

Reviewed By: cortinico

Differential Revision: D44375081

fbshipit-source-id: c8dbd5694d3a728a0a2091210894d27c9d84a012
jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#36632

Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public.

Changelog:
[General][Fixed] -  Export EmitterSubscription TypeScript Type

Reviewed By: cortinico

Differential Revision: D44375081

fbshipit-source-id: c8dbd5694d3a728a0a2091210894d27c9d84a012
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36632

Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public.

Changelog:
[General][Fixed] -  Export EmitterSubscription TypeScript Type

Reviewed By: cortinico

Differential Revision: D44375081

fbshipit-source-id: c8dbd5694d3a728a0a2091210894d27c9d84a012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants