add RNTester-E2E: tests for iOS and Android via Appium, WDIO and Jest #36267

kelset · 2023-02-23T12:12:30Z

Summary:

The motivation is to create an E2E testing solution for the RNTester app that can be used to flag when things break and the release crew can use to validate more of the codebase ahead of a release.

This first PR wants to just showcase the main flow (how tests are made, where the E2E folder lives, how it's used by CircleCI) and then we can build on top of it with subsequent PRs, with the help of an umbrella issue to get the community involved in making more tests!

This work is being done cooperation with Callstack developers (@mateuszm22 , @adzironman, and others) - reason why the branch lives in a fork.

Read the RFC for more details

Extra notes

We are still on WebDriverIO 7 because during the exploratory phase, WDIO was a bit problematic and the workarounds needed to make it work don't seem very nice - see this PR: kelset/react-native-e2e-jest-appium-webdriverio#4 --- this will be revisited in the future, once there's a better path for upgrading.

Things that will be handled as follow up work

Changelog:

[INTERNAL] [ADDED] - Added first working configuration for e2e testing

Test Plan:

You can play with this locally by follow the readme.

CircleCI jobs will be added.

packages/rn-tester-e2e/test/screenObjects/buttonComponent.screen.js

analysis-bot · 2023-02-23T12:35:38Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,843,684	+241
android	hermes	armeabi-v7a	8,152,833	+235
android	hermes	x86	9,349,469	+234
android	hermes	x86_64	9,192,198	+242
android	jsc	arm64-v8a	9,456,909	+46
android	jsc	armeabi-v7a	8,638,042	+45
android	jsc	x86	9,539,996	+46
android	jsc	x86_64	9,783,297	+49

Base commit: e64756a
Branch: main

packages/rn-tester-e2e/README.md

facebook-github-bot · 2023-05-26T15:05:19Z

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

packages/rn-tester-e2e/tests/screens/components.screen.js

packages/rn-tester-e2e/tests/screens/components/buttonComponent.screen.js

packages/rn-tester-e2e/tests/specs/components/buttonComponentScreen.test.js

facebook-github-bot · 2023-07-25T17:31:46Z

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2023-07-26T02:31:24Z

This pull request has been reverted by dd1c8a6.

facebook-github-bot · 2023-07-26T02:32:05Z

@cortinico merged this pull request in 3c196fb.

github-actions · 2023-07-26T14:27:41Z

This pull request was successfully merged by @kelset in 3c6dbec.

^{When will my fix make it into a release? | Upcoming Releases}

facebook-github-bot · 2023-07-26T14:27:45Z

@cortinico merged this pull request in 3c6dbec.

christian-bromann · 2023-07-28T16:14:18Z

Hey 👋 WebdriverIO maintainer here!

It's excited to see RN using WebdriverIO for their e2e testing. Please don't hesitate to reach out to me if there are any questions or issues coming up. Looking at the code changes I was wondering why you have decided to use Jest as oppose to the WebdriverIO testrunner? The testrunner was designed to allow people to scale their e2e tests and provide good reporting and plugin capabilities. For example it could simplify setting up Appium using the @wdio/appium-service.

Any feedback would be greatly appreciated and helps making WebdriverIO better. Cheers!

…facebook#36267) Summary: The motivation is to create an E2E testing solution for the RNTester app that can be used to flag when things break and the release crew can use to validate more of the codebase ahead of a release. This first PR wants to just showcase the main flow (how tests are made, where the E2E folder lives, how it's used by CircleCI) and then we can build on top of it with subsequent PRs, with the help of an umbrella issue to get the community involved in making more tests! This work is being done cooperation with Callstack developers (mateuszm22 , adzironman, and others) - reason why the branch [lives in a fork](https://github.com/mateuszm22/react-native/tree/k%2Bm/new-rn-tester-E2E). ### [Read the RFC for more details ](react-native-community/discussions-and-proposals#684) ### Extra notes We are still on WebDriverIO 7 because during the exploratory phase, WDIO was a bit problematic and the workarounds needed to make it work don't seem very nice - see this PR: kelset/react-native-e2e-jest-appium-webdriverio#4 --- this will be revisited in the future, once there's a better path for upgrading. ### Things that will be handled as follow up work * upgrade to WDIO 8 * [an automated yarn run-e2e-test script](facebook#36267 (comment)) * [a small refactoring into a js script](facebook#36267 (comment)) ## Changelog: [INTERNAL] [ADDED] - Added first working configuration for e2e testing Pull Request resolved: facebook#36267 Test Plan: You can play with this locally by [follow the readme](https://github.com/mateuszm22/react-native/blob/k+m/new-rn-tester-E2E/packages/rn-tester-e2e/README.md). CircleCI jobs will be added. Reviewed By: cipolleschi Differential Revision: D46225747 Pulled By: cortinico fbshipit-source-id: e5428c439afd84ed3dd219d6ada538263120d7c6

…facebook#36267) Summary: The motivation is to create an E2E testing solution for the RNTester app that can be used to flag when things break and the release crew can use to validate more of the codebase ahead of a release. This first PR wants to just showcase the main flow (how tests are made, where the E2E folder lives, how it's used by CircleCI) and then we can build on top of it with subsequent PRs, with the help of an umbrella issue to get the community involved in making more tests! This work is being done cooperation with Callstack developers (mateuszm22 , adzironman, and others) - reason why the branch [lives in a fork](https://github.com/mateuszm22/react-native/tree/k%2Bm/new-rn-tester-E2E). ### [Read the RFC for more details ](react-native-community/discussions-and-proposals#684) ### Extra notes We are still on WebDriverIO 7 because during the exploratory phase, WDIO was a bit problematic and the workarounds needed to make it work don't seem very nice - see this PR: kelset/react-native-e2e-jest-appium-webdriverio#4 --- this will be revisited in the future, once there's a better path for upgrading. ### Things that will be handled as follow up work * upgrade to WDIO 8 * [an automated yarn run-e2e-test script](facebook#36267 (comment)) * [a small refactoring into a js script](facebook#36267 (comment)) ## Changelog: [INTERNAL] [ADDED] - Added first working configuration for e2e testing Pull Request resolved: facebook#36267 Test Plan: You can play with this locally by [follow the readme](https://github.com/mateuszm22/react-native/blob/k+m/new-rn-tester-E2E/packages/rn-tester-e2e/README.md). CircleCI jobs will be added. Reviewed By: cipolleschi Differential Revision: D47763012 Pulled By: cortinico fbshipit-source-id: 6eb9674182b8ee97aea4784158c69bf017f379e5

…facebook#36267) Summary: The motivation is to create an E2E testing solution for the RNTester app that can be used to flag when things break and the release crew can use to validate more of the codebase ahead of a release. This first PR wants to just showcase the main flow (how tests are made, where the E2E folder lives, how it's used by CircleCI) and then we can build on top of it with subsequent PRs, with the help of an umbrella issue to get the community involved in making more tests! This work is being done cooperation with Callstack developers (mateuszm22 , adzironman, and others) - reason why the branch [lives in a fork](https://github.com/mateuszm22/react-native/tree/k%2Bm/new-rn-tester-E2E). ### [Read the RFC for more details ](react-native-community/discussions-and-proposals#684) ### Extra notes We are still on WebDriverIO 7 because during the exploratory phase, WDIO was a bit problematic and the workarounds needed to make it work don't seem very nice - see this PR: kelset/react-native-e2e-jest-appium-webdriverio#4 --- this will be revisited in the future, once there's a better path for upgrading. ### Things that will be handled as follow up work * upgrade to WDIO 8 * [an automated yarn run-e2e-test script](facebook#36267 (comment)) * [a small refactoring into a js script](facebook#36267 (comment)) ## Changelog: [INTERNAL] [ADDED] - Added first working configuration for e2e testing Pull Request resolved: facebook#36267 Test Plan: You can play with this locally by [follow the readme](https://github.com/mateuszm22/react-native/blob/k+m/new-rn-tester-E2E/packages/rn-tester-e2e/README.md). CircleCI jobs will be added. Reviewed By: cipolleschi Differential Revision: D46225747 Pulled By: cortinico fbshipit-source-id: e5428c439afd84ed3dd219d6ada538263120d7c6

…facebook#36267) Summary: The motivation is to create an E2E testing solution for the RNTester app that can be used to flag when things break and the release crew can use to validate more of the codebase ahead of a release. This first PR wants to just showcase the main flow (how tests are made, where the E2E folder lives, how it's used by CircleCI) and then we can build on top of it with subsequent PRs, with the help of an umbrella issue to get the community involved in making more tests! This work is being done cooperation with Callstack developers (mateuszm22 , adzironman, and others) - reason why the branch [lives in a fork](https://github.com/mateuszm22/react-native/tree/k%2Bm/new-rn-tester-E2E). ### [Read the RFC for more details ](react-native-community/discussions-and-proposals#684) ### Extra notes We are still on WebDriverIO 7 because during the exploratory phase, WDIO was a bit problematic and the workarounds needed to make it work don't seem very nice - see this PR: kelset/react-native-e2e-jest-appium-webdriverio#4 --- this will be revisited in the future, once there's a better path for upgrading. ### Things that will be handled as follow up work * upgrade to WDIO 8 * [an automated yarn run-e2e-test script](facebook#36267 (comment)) * [a small refactoring into a js script](facebook#36267 (comment)) ## Changelog: [INTERNAL] [ADDED] - Added first working configuration for e2e testing Pull Request resolved: facebook#36267 Test Plan: You can play with this locally by [follow the readme](https://github.com/mateuszm22/react-native/blob/k+m/new-rn-tester-E2E/packages/rn-tester-e2e/README.md). CircleCI jobs will be added. Reviewed By: cipolleschi Differential Revision: D47763012 Pulled By: cortinico fbshipit-source-id: 6eb9674182b8ee97aea4784158c69bf017f379e5

…facebook#36267) Summary: The motivation is to create an E2E testing solution for the RNTester app that can be used to flag when things break and the release crew can use to validate more of the codebase ahead of a release. This first PR wants to just showcase the main flow (how tests are made, where the E2E folder lives, how it's used by CircleCI) and then we can build on top of it with subsequent PRs, with the help of an umbrella issue to get the community involved in making more tests! This work is being done cooperation with Callstack developers (mateuszm22 , adzironman, and others) - reason why the branch [lives in a fork](https://github.com/mateuszm22/react-native/tree/k%2Bm/new-rn-tester-E2E). ### [Read the RFC for more details ](react-native-community/discussions-and-proposals#684) ### Extra notes We are still on WebDriverIO 7 because during the exploratory phase, WDIO was a bit problematic and the workarounds needed to make it work don't seem very nice - see this PR: kelset/react-native-e2e-jest-appium-webdriverio#4 --- this will be revisited in the future, once there's a better path for upgrading. ### Things that will be handled as follow up work * upgrade to WDIO 8 * [an automated yarn run-e2e-test script](facebook#36267 (comment)) * [a small refactoring into a js script](facebook#36267 (comment)) ## Changelog: [INTERNAL] [ADDED] - Added first working configuration for e2e testing Pull Request resolved: facebook#36267 Test Plan: You can play with this locally by [follow the readme](https://github.com/mateuszm22/react-native/blob/k+m/new-rn-tester-E2E/packages/rn-tester-e2e/README.md). CircleCI jobs will be added. Reviewed By: cipolleschi Differential Revision: D46225747 Pulled By: cortinico fbshipit-source-id: e5428c439afd84ed3dd219d6ada538263120d7c6

…facebook#36267) Summary: The motivation is to create an E2E testing solution for the RNTester app that can be used to flag when things break and the release crew can use to validate more of the codebase ahead of a release. This first PR wants to just showcase the main flow (how tests are made, where the E2E folder lives, how it's used by CircleCI) and then we can build on top of it with subsequent PRs, with the help of an umbrella issue to get the community involved in making more tests! This work is being done cooperation with Callstack developers (mateuszm22 , adzironman, and others) - reason why the branch [lives in a fork](https://github.com/mateuszm22/react-native/tree/k%2Bm/new-rn-tester-E2E). ### [Read the RFC for more details ](react-native-community/discussions-and-proposals#684) ### Extra notes We are still on WebDriverIO 7 because during the exploratory phase, WDIO was a bit problematic and the workarounds needed to make it work don't seem very nice - see this PR: kelset/react-native-e2e-jest-appium-webdriverio#4 --- this will be revisited in the future, once there's a better path for upgrading. ### Things that will be handled as follow up work * upgrade to WDIO 8 * [an automated yarn run-e2e-test script](facebook#36267 (comment)) * [a small refactoring into a js script](facebook#36267 (comment)) ## Changelog: [INTERNAL] [ADDED] - Added first working configuration for e2e testing Pull Request resolved: facebook#36267 Test Plan: You can play with this locally by [follow the readme](https://github.com/mateuszm22/react-native/blob/k+m/new-rn-tester-E2E/packages/rn-tester-e2e/README.md). CircleCI jobs will be added. Reviewed By: cipolleschi Differential Revision: D47763012 Pulled By: cortinico fbshipit-source-id: 6eb9674182b8ee97aea4784158c69bf017f379e5

Summary: This PR is small cleanup in `.circleci/config.yml` file. Request here: #36267 (comment) ## Changelog: [INTERNAL] [CHANGED] - move script checking Appium server status to separate file Pull Request resolved: #38692 Test Plan: CI Green ✅ Reviewed By: NickGerleman Differential Revision: D47926222 Pulled By: ryancat fbshipit-source-id: eeff338ca018549762dce46a744b80f659b4bd5d

kelset · 2023-08-01T09:45:49Z

Looking at the code changes I was wondering why you have decided to use Jest as oppose to the WebdriverIO testrunner?

They @christian-bromann - thanks for your comment! We'll surely reach out if we need help 🤗 About your question, the tl;dr is that using Jest was a strict requirement, you can read more in the RFC

Summary: This PR is small cleanup in scripts in `rn-tester-e2e` package, it creates unified script so that we can easily pass platform as an argument. Context: #36267 (comment) ## Changelog: [INTERNAL] [CHANGED] - Unify `test-e2e` command in `rn-tester-e2e` package Pull Request resolved: #38701 Test Plan: CI Green ✅ Reviewed By: NickGerleman, cipolleschi Differential Revision: D47949821 Pulled By: cortinico fbshipit-source-id: 90bbc96281e89dec505999ff5e51db7ca78da6dc

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Feb 23, 2023

This was referenced Feb 23, 2023

RNTester: Setup E2E tests for iOS and Android with Appium and Jest #35016

Closed

RNTester: Setup E2E tests for iOS and Android with Appium, Jest and Cucumber #35824

Closed

react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Feb 23, 2023

kelset requested a review from cortinico February 23, 2023 12:20

kelset commented Feb 23, 2023

View reviewed changes

packages/rn-tester-e2e/test/screenObjects/buttonComponent.screen.js Outdated Show resolved Hide resolved

kelset mentioned this pull request Mar 10, 2023

bump to RN0.71 & Appium 2 beta kelset/react-native-e2e-jest-appium-webdriverio#2

Merged

kelset force-pushed the k+m/new-rn-tester-E2E branch 2 times, most recently from 0db60ac to 969793b Compare March 21, 2023 11:52

kelset force-pushed the k+m/new-rn-tester-E2E branch from 969793b to ec894f1 Compare April 13, 2023 10:18

kelset added the p: Callstack Partner: Callstack label Apr 13, 2023

kelset marked this pull request as ready for review April 13, 2023 14:19

kelset force-pushed the k+m/new-rn-tester-E2E branch from 654bbb7 to a66f358 Compare April 13, 2023 14:20

kelset changed the title ~~add RNTester-E2E: tests for iOS and Android via Appium, WDIO and Jest (WIP)~~ add RNTester-E2E: tests for iOS and Android via Appium, WDIO and Jest Apr 13, 2023

kelset force-pushed the k+m/new-rn-tester-E2E branch from a03d473 to 15a5d0f Compare April 13, 2023 14:40

szymonrybczak reviewed Apr 27, 2023

View reviewed changes

packages/rn-tester-e2e/README.md Outdated Show resolved Hide resolved

szymonrybczak reviewed Apr 27, 2023

View reviewed changes

packages/rn-tester-e2e/README.md Outdated Show resolved Hide resolved

kelset force-pushed the k+m/new-rn-tester-E2E branch 4 times, most recently from 16996ad to 00932ab Compare May 25, 2023 13:23

cipolleschi reviewed May 27, 2023

View reviewed changes

packages/rn-tester-e2e/tests/screens/components.screen.js Outdated Show resolved Hide resolved

cipolleschi reviewed May 27, 2023

View reviewed changes

packages/rn-tester-e2e/tests/screens/components/buttonComponent.screen.js Outdated Show resolved Hide resolved

cipolleschi reviewed May 27, 2023

View reviewed changes

packages/rn-tester-e2e/tests/screens/components/buttonComponent.screen.js Outdated Show resolved Hide resolved

cipolleschi reviewed May 27, 2023

View reviewed changes

packages/rn-tester-e2e/tests/specs/components/buttonComponentScreen.test.js Show resolved Hide resolved

cortinico force-pushed the k+m/new-rn-tester-E2E branch from a026fbb to 7985e5c Compare July 25, 2023 17:27

cortinico closed this Jul 25, 2023

cortinico reopened this Jul 25, 2023

facebook-github-bot added the Reverted label Jul 26, 2023

facebook-github-bot closed this in 3c196fb Jul 26, 2023

facebook-github-bot added the Merged This PR has been merged. label Jul 26, 2023

cortinico reopened this Jul 26, 2023

cortinico removed Merged This PR has been merged. Reverted labels Jul 26, 2023

facebook-github-bot closed this in 3c6dbec Jul 26, 2023

github-actions bot added the Merged This PR has been merged. label Jul 26, 2023

This was referenced Jul 31, 2023

Move script checking Appium server status to separate file #38692

Closed

Unify test-e2e command in rn-tester-e2e pacakge #38701

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add RNTester-E2E: tests for iOS and Android via Appium, WDIO and Jest #36267

add RNTester-E2E: tests for iOS and Android via Appium, WDIO and Jest #36267

kelset commented Feb 23, 2023 •

edited

Loading

analysis-bot commented Feb 23, 2023 •

edited

Loading

facebook-github-bot commented May 26, 2023

facebook-github-bot commented Jul 25, 2023

facebook-github-bot commented Jul 26, 2023

facebook-github-bot commented Jul 26, 2023

github-actions bot commented Jul 26, 2023

facebook-github-bot commented Jul 26, 2023

christian-bromann commented Jul 28, 2023

kelset commented Aug 1, 2023

add RNTester-E2E: tests for iOS and Android via Appium, WDIO and Jest #36267

add RNTester-E2E: tests for iOS and Android via Appium, WDIO and Jest #36267

Conversation

kelset commented Feb 23, 2023 • edited Loading

Summary:

Read the RFC for more details

Extra notes

Things that will be handled as follow up work

Changelog:

Test Plan:

analysis-bot commented Feb 23, 2023 • edited Loading

facebook-github-bot commented May 26, 2023

facebook-github-bot commented Jul 25, 2023

facebook-github-bot commented Jul 26, 2023

facebook-github-bot commented Jul 26, 2023

github-actions bot commented Jul 26, 2023

facebook-github-bot commented Jul 26, 2023

christian-bromann commented Jul 28, 2023

kelset commented Aug 1, 2023

kelset commented Feb 23, 2023 •

edited

Loading

analysis-bot commented Feb 23, 2023 •

edited

Loading