Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew should overwrite existing python links #36192

Closed
wants to merge 1 commit into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Feb 17, 2023

Summary:
Builds are failing on CI because brew bails out when it tries installing Python 3.1. The image already has an existing version of Python 3, which we should overwrite.

Changelog:
[General][Changed] - Brew overwrites system Python 3.

Differential Revision: D43391941

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Feb 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43391941

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,451,399 -2,934
android hermes armeabi-v7a 7,774,782 -2,954
android hermes x86 8,927,004 -3,985
android hermes x86_64 8,784,617 -3,888
android jsc arm64-v8a 6,668,092 +0
android jsc armeabi-v7a 7,462,048 +0
android jsc x86 9,192,215 +0
android jsc x86_64 6,893,219 +0

Base commit: 3218680
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43391941

blakef added a commit to blakef/react-native that referenced this pull request Feb 17, 2023
Summary:
Pull Request resolved: facebook#36192

Builds are failing on CI because brew bails out when it tries installing Python 3.1. The image already has an existing version of Python 3, which we should overwrite.

{F876436464}

This seems to be a known issue [1] with Brew. In this case it seems safe to overwrite.

Changelog:
[General][Changed] - Brew overwrites system Python 3.

[1] actions/setup-python#577 (comment)

Reviewed By: cipolleschi

Differential Revision: D43391941

fbshipit-source-id: 14cc887f89930e1fb1521222536cdc81e3a0dd89
Summary:
Pull Request resolved: facebook#36192

Builds are failing on CI because brew bails out when it tries installing Python 3.1. The image already has an existing version of Python 3, which we should overwrite.

{F876436464}

This seems to be a known issue [1] with Brew. In this case it seems safe to overwrite.

Changelog:
[General][Changed] - Brew overwrites system Python 3.

[1] actions/setup-python#577 (comment)

Reviewed By: cipolleschi

Differential Revision: D43391941

fbshipit-source-id: e17484f3a4bdb1d126acb37172e7c3354233e6cd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43391941

@blakef
Copy link
Contributor Author

blakef commented Feb 17, 2023

Conflict was resolved and merged.

@blakef blakef closed this Feb 17, 2023
@blakef blakef deleted the export-D43391941 branch February 17, 2023 16:11
facebook-github-bot pushed a commit that referenced this pull request Feb 17, 2023
Summary:
Pull Request resolved: #36192

Builds are failing on CI because brew bails out when it tries installing Python 3.1. The image already has an existing version of Python 3, which we should overwrite.

{F876436464}

This seems to be a known issue [1] with Brew. In this case it seems safe to overwrite.

Changelog:
[General][Changed] - Brew overwrites system Python 3.

[1] actions/setup-python#577 (comment)

Reviewed By: cipolleschi

Differential Revision: D43391941

fbshipit-source-id: 9b0cb234eeb0b7473b17b5ebfa6ed12c6448760f
@github-actions
Copy link

This pull request was successfully merged by @blakef in ed8a3e0.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Feb 17, 2023
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36192

Builds are failing on CI because brew bails out when it tries installing Python 3.1. The image already has an existing version of Python 3, which we should overwrite.

{F876436464}

This seems to be a known issue [1] with Brew. In this case it seems safe to overwrite.

Changelog:
[General][Changed] - Brew overwrites system Python 3.

[1] actions/setup-python#577 (comment)

Reviewed By: cipolleschi

Differential Revision: D43391941

fbshipit-source-id: 9b0cb234eeb0b7473b17b5ebfa6ed12c6448760f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants