-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RN][Android] Make it easier for users to build from source if needed #36165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Feb 15, 2023
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cortinico merged this pull request in 4a07ed2. |
kelset
pushed a commit
that referenced
this pull request
Mar 6, 2023
Summary: This page is not up to date anymore: https://reactnative.dev/contributing/how-to-build-from-source I'm pushing those changes to make it easier to consume our build when building from source. I'll update the page those change lands. ## Changelog [Internal] [Changed] - Make it easier for users to build from source if needed Pull Request resolved: #36165 Test Plan: If the CI is green, we should be good to merge this Reviewed By: cipolleschi Differential Revision: D43303867 Pulled By: cortinico fbshipit-source-id: c0080b06cbcbf872ee92fcfa82a9f823d5b247f4
cortinico
added a commit
that referenced
this pull request
Mar 6, 2023
Summary: This page is not up to date anymore: https://reactnative.dev/contributing/how-to-build-from-source I'm pushing those changes to make it easier to consume our build when building from source. I'll update the page those change lands. ## Changelog [Internal] [Changed] - Make it easier for users to build from source if needed Pull Request resolved: #36165 Test Plan: If the CI is green, we should be good to merge this Reviewed By: cipolleschi Differential Revision: D43303867 Pulled By: cortinico fbshipit-source-id: c0080b06cbcbf872ee92fcfa82a9f823d5b247f4
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This page is not up to date anymore: https://reactnative.dev/contributing/how-to-build-from-source I'm pushing those changes to make it easier to consume our build when building from source. I'll update the page those change lands. ## Changelog [Internal] [Changed] - Make it easier for users to build from source if needed Pull Request resolved: facebook#36165 Test Plan: If the CI is green, we should be good to merge this Reviewed By: cipolleschi Differential Revision: D43303867 Pulled By: cortinico fbshipit-source-id: c0080b06cbcbf872ee92fcfa82a9f823d5b247f4
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This page is not up to date anymore:
https://reactnative.dev/contributing/how-to-build-from-source
I'm pushing those changes to make it easier to consume our build when building from source.
I'll update the page those change lands.
Changelog
[Internal] [Changed] - Make it easier for users to build from source if needed
Test Plan
If the CI is green, we should be good to merge this