Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOS] Add smartInsertDelete prop to TextInput component #36111

Conversation

fabioh8010
Copy link
Contributor

@fabioh8010 fabioh8010 commented Feb 9, 2023

Summary:

This PR add support to configure the smartInsertDeleteType property in iOS inputs as described here, making possible toggle this autoformatting behavior.

PR for the docs update: facebook/react-native-website#3560

Changelog:

[IOS] [ADDED] - Add smartInsertDelete prop to TextInput component

Test Plan:

  • Added an example in the RNTester app to test this behavior in iOS.
  • If the smartInsertDelete prop is true or undefined, the system will use the default autoformatting behavior.
  • If the smartInsertDelete prop is false, the system will disable the autoformatting behavior.
Simulator.Screen.Recording.-.iPhone.14.-.2023-02-09.at.15.40.07.mp4

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 9, 2023
@analysis-bot
Copy link

analysis-bot commented Feb 9, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,744,424 +0
android hermes armeabi-v7a 8,056,632 +1
android hermes x86 9,235,553 +1
android hermes x86_64 9,086,370 -11
android jsc arm64-v8a 9,307,282 +16
android jsc armeabi-v7a 8,496,823 +10
android jsc x86 9,369,291 +7
android jsc x86_64 9,624,213 +8

Base commit: e449706
Branch: main

@mountiny
Copy link

mountiny commented Feb 9, 2023

Nice improvement! 😍

@ArjunSharda
Copy link

Great!

@NickGerleman
Copy link
Contributor

@fabioh8010 could you rebase?

@fabioh8010 fabioh8010 force-pushed the feature/text-input-ios-autoformatting-behaviors branch from afb2f95 to 8fc4331 Compare June 7, 2023 15:04
@fabioh8010
Copy link
Contributor Author

@NickGerleman done!

@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 8, 2023
@facebook-github-bot
Copy link
Contributor

@NickGerleman merged this pull request in 6b62f12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants