Turbo module codegen support interface like alias in module #35812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Closed
Base commit: ac54a5b |
cipolleschi
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Code looks good. Just to double-check: do we need something similar with Components also?
I'm thinking about a component with some props like:
interface BaseProps {
sharedProp: number
}
interface iOSProps extends BaseProps {
iOSProp: number
}
interface AndroidProps extends BaseProps {
androidProp: number
}If we need it, it is fine to add it in a new PR, though.
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Jan 12, 2023
|
@cipolleschi merged this pull request in 8befb74. |
|
@cipolleschi Hi, component doesn't support alias, all interfaces or aliases got inlined into the component. And I remember I've already made interface features available for component before as data types, as a component itself is not tested though. |
|
Hey Guys, it's released? |
@migueldaipre Nope this will land in 0.72 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
…6011) Summary: The [previous pull request](#35812) enables defining interfaces and using them in a turbo module, but all members are flattened, this is not the best option for codegen for object oriented languages. In this pull request, an optional member `baseTypes` is added to aliased objects. Members are still flattened for backward compatibility, if a codegen doesn't care about that nothing needs to be changed. ### Example ```typescript interface A { a : string; } interface B extends A { b : number; } ``` #### Before the previous pull request `interface` is not allowed here, you must use type alias. #### At the previous pull request `interface` is allowed, but it is translated to ```typescript type A = {a : string}; type B = {a : string, b : number}; ``` #### At this pull request Extra information is provided so that you know `B` extends `A`. By comparing `B` to `A` it is easy to know that `B::a` is obtained from `A`. ## Changelog [GENERAL] [CHANGED] - Turbo module codegen support interface with inheritance in module Pull Request resolved: #36011 Test Plan: `yarn jest react-native-codegen` passed Reviewed By: rshest Differential Revision: D42882650 Pulled By: cipolleschi fbshipit-source-id: 32d502e8a99c4151fae0a1f4dfa60db9ac827963
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…#35812) Summary: Turbo module codegen support interface like alias in module. In typescript, interface allows inheritance, but the codegen schema doesn't have such information. In this PR the codegen schema is not changed, interfaces are flattened. In the next change, I will update the codegen schema so that it allows inheritance, in order to generate more precise C++ code. ## Changelog [GENERAL] [CHANGED] - Turbo module codegen support interface like alias in module Pull Request resolved: facebook#35812 Test Plan: `yarn jest react-native-codegen` passed Reviewed By: cortinico Differential Revision: D42475368 Pulled By: cipolleschi fbshipit-source-id: 26025f8a55b600dfea27026c998cd8b5fe752af4
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…cebook#36011) Summary: The [previous pull request](facebook#35812) enables defining interfaces and using them in a turbo module, but all members are flattened, this is not the best option for codegen for object oriented languages. In this pull request, an optional member `baseTypes` is added to aliased objects. Members are still flattened for backward compatibility, if a codegen doesn't care about that nothing needs to be changed. ### Example ```typescript interface A { a : string; } interface B extends A { b : number; } ``` #### Before the previous pull request `interface` is not allowed here, you must use type alias. #### At the previous pull request `interface` is allowed, but it is translated to ```typescript type A = {a : string}; type B = {a : string, b : number}; ``` #### At this pull request Extra information is provided so that you know `B` extends `A`. By comparing `B` to `A` it is easy to know that `B::a` is obtained from `A`. ## Changelog [GENERAL] [CHANGED] - Turbo module codegen support interface with inheritance in module Pull Request resolved: facebook#36011 Test Plan: `yarn jest react-native-codegen` passed Reviewed By: rshest Differential Revision: D42882650 Pulled By: cipolleschi fbshipit-source-id: 32d502e8a99c4151fae0a1f4dfa60db9ac827963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turbo module codegen support interface like alias in module.
In typescript, interface allows inheritance, but the codegen schema doesn't have such information. In this PR the codegen schema is not changed, interfaces are flattened.
In the next change, I will update the codegen schema so that it allows inheritance, in order to generate more precise C++ code.
Changelog
[GENERAL] [CHANGED] - Turbo module codegen support interface like alias in module
Test Plan
yarn jest react-native-codegenpassed