Void the Maven coordinates for react-native and hermes-engine #35379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
This diff moves the publishing coordinates from:
```
com.facebook.react:react-native
com.facebook.react:hermes-engine
```
to
```
com.facebook.react:react-android
com.facebook.react:hermes-android
```
I've picked those they are the most layout friendly when building from source, but we can discuss if we want others.
I've updated the Gradle plugin to have a dependencySubstitution rule + update the template with those changes.
It should now be possible to still use `implementation("com.facebook.react:react-native:+")` inside libraries
on 0.71+ and RNGP will resolve dependencies correctly.
Changelog:
[Android] [Changed] - Void the Maven coordinates for react-native and hermes-engine
Differential Revision: D41380525
fbshipit-source-id: 8e4e439ebaf6dba3b24aecd455d526af62158c9c
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41380525 |
Base commit: 04c286c |
Base commit: 3681df2 |
|
PR build artifact for 705c3f2 is ready. |
|
PR build artifact for 705c3f2 is ready. |
|
This needs a bump + release of the Gradle Plugin in order for the CI to be green |
ok so it sounds like we need to do the bump here in main (so to RNGP 0.72) and then to cherry-pick the necessary changes + new release of RNGP on 0.71 |
kelset
pushed a commit
that referenced
this pull request
Nov 22, 2022
Summary: Pull Request resolved: #35379 This diff moves the publishing coordinates from: ``` com.facebook.react:react-native com.facebook.react:hermes-engine ``` to ``` com.facebook.react:react-android com.facebook.react:hermes-android ``` I've picked those they are the most layout friendly when building from source, but we can discuss if we want others. I've updated the Gradle plugin to have a dependencySubstitution rule + update the template with those changes. It should now be possible to still use `implementation("com.facebook.react:react-native:+")` inside libraries on 0.71+ and RNGP will resolve dependencies correctly. Changelog: [Android] [Changed] - Void the Maven coordinates for react-native and hermes-engine Reviewed By: cipolleschi Differential Revision: D41380525 fbshipit-source-id: 91e059fa261acb89bee7ca0c79c30c3d856a2c80
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ok#35379) Summary: Pull Request resolved: facebook#35379 This diff moves the publishing coordinates from: ``` com.facebook.react:react-native com.facebook.react:hermes-engine ``` to ``` com.facebook.react:react-android com.facebook.react:hermes-android ``` I've picked those they are the most layout friendly when building from source, but we can discuss if we want others. I've updated the Gradle plugin to have a dependencySubstitution rule + update the template with those changes. It should now be possible to still use `implementation("com.facebook.react:react-native:+")` inside libraries on 0.71+ and RNGP will resolve dependencies correctly. Changelog: [Android] [Changed] - Void the Maven coordinates for react-native and hermes-engine Reviewed By: cipolleschi Differential Revision: D41380525 fbshipit-source-id: 91e059fa261acb89bee7ca0c79c30c3d856a2c80
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff moves the publishing coordinates from:
to
I've picked those they are the most layout friendly when building from source, but we can discuss if we want others.
I've updated the Gradle plugin to have a dependencySubstitution rule + update the template with those changes.
It should now be possible to still use
implementation("com.facebook.react:react-native:+")inside librarieson 0.71+ and RNGP will resolve dependencies correctly.
Changelog:
[Android] [Changed] - Void the Maven coordinates for react-native and hermes-engine
Differential Revision: D41380525