Let danger run on pull_request_target
#34370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @cortinico in 665b5be. When will my fix make it into a release? | Upcoming Releases |
|
I think that this broke something with the danger tokens, like here. @cortinico |
Yup my bad. I missed a: |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 10, 2022
Summary: After #34370, Danger started failing because the `DANGER_GITHUB_API_TOKEN` was not properly set. This PR fixes it. ## Changelog [General] [Changed] - Set back the `DANGER_GITHUB_API_TOKEN`. Pull Request resolved: #34375 Test Plan: Danger GitHub action is executed correctly. Reviewed By: cortinico Differential Revision: D38571718 Pulled By: cipolleschi fbshipit-source-id: 51168098b4f910f6fefd2872f917e12daad1ec4c
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: This is a nit. Did some cleanups on our Danger setup. The most substantial work is: - Moved over danger to run on `pull_request_target`. This allow us to re-use the Github Action access token without having to provide one. - Fixed an issue with the `Pick Request` label which was not applied correctly. - Removed the danger_id as we were not passing it correctly. ## Changelog [Internal] - Let danger run on `pull_request_target` Pull Request resolved: facebook#34370 Test Plan: Tested locally with `yarn danger pr https://github.com/facebook/react-native/pull/34197` Reviewed By: cipolleschi Differential Revision: D38533144 Pulled By: cortinico fbshipit-source-id: 178ce411eb956870563c4d51719ed4dae1f1536d
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: After facebook#34370, Danger started failing because the `DANGER_GITHUB_API_TOKEN` was not properly set. This PR fixes it. ## Changelog [General] [Changed] - Set back the `DANGER_GITHUB_API_TOKEN`. Pull Request resolved: facebook#34375 Test Plan: Danger GitHub action is executed correctly. Reviewed By: cortinico Differential Revision: D38571718 Pulled By: cipolleschi fbshipit-source-id: 51168098b4f910f6fefd2872f917e12daad1ec4c
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: This is a nit. Did some cleanups on our Danger setup. The most substantial work is: - Moved over danger to run on `pull_request_target`. This allow us to re-use the Github Action access token without having to provide one. - Fixed an issue with the `Pick Request` label which was not applied correctly. - Removed the danger_id as we were not passing it correctly. ## Changelog [Internal] - Let danger run on `pull_request_target` Pull Request resolved: facebook#34370 Test Plan: Tested locally with `yarn danger pr https://github.com/facebook/react-native/pull/34197` Reviewed By: cipolleschi Differential Revision: D38533144 Pulled By: cortinico fbshipit-source-id: 178ce411eb956870563c4d51719ed4dae1f1536d
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: After facebook#34370, Danger started failing because the `DANGER_GITHUB_API_TOKEN` was not properly set. This PR fixes it. ## Changelog [General] [Changed] - Set back the `DANGER_GITHUB_API_TOKEN`. Pull Request resolved: facebook#34375 Test Plan: Danger GitHub action is executed correctly. Reviewed By: cortinico Differential Revision: D38571718 Pulled By: cipolleschi fbshipit-source-id: 51168098b4f910f6fefd2872f917e12daad1ec4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a nit. Did some cleanups on our Danger setup.
The most substantial work is:
pull_request_target. This allow us to re-use the Github Action access token without having to provide one.Pick Requestlabel which was not applied correctly.Changelog
[Internal] - Let danger run on
pull_request_targetTest Plan
Tested locally with
yarn danger pr https://github.com/facebook/react-native/pull/34197