Move utilities out of react_native_pods - Part 2
#33982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2022 06:56
Summary: Pull Request resolved: facebook#33978 This Diff moves part of the utilities from the `react_native_pods` file to a specific `utils.rb` file. It adds tests for these utils and improve our test mocks. The goal is to simplify the `react_native_pods.rb` so it's easier to work with it. I decided to split this diff in 2 because it was becoming quite big. ## Changelog [iOS][Changed] - Refactoring part of the react_native_pods.rb script Differential Revision: D37004347 fbshipit-source-id: ecc1b1cb0825440e9e5ae5a92846bc8fe8602d99
Summary: This Diff moves another part of the utilities from the `react_native_pods` file to a specific `utils.rb` file. It adds tests for these utils and improve our test mocks. The goal is to simplify the `react_native_pods.rb` so it's easier to work with it. I decided to split this diff in 2 because it was becoming quite big. ## Changelog [iOS][Changed] - Refactoring part of the react_native_pods.rb script Differential Revision: D37006265 fbshipit-source-id: 580152f6f3bc97c78e23d1004695c60a718c875c
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37006265 |
Base commit: a0e6ffe |
Base commit: a0e6ffe |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 10, 2022
Summary: Pull Request resolved: facebook#33982 This Diff moves another part of the utilities from the `react_native_pods` file to a specific `utils.rb` file. It adds tests for these utils and improve our test mocks. The goal is to simplify the `react_native_pods.rb` so it's easier to work with it. I decided to split this diff in 2 because it was becoming quite big. ## Changelog [iOS][Changed] - Refactoring part of the react_native_pods.rb script Differential Revision: https://www.internalfb.com/diff/D37006265?entry_point=27 fbshipit-source-id: 204470a68d5a5da137c1f698f413fd9c66618076
|
This pull request was successfully merged by @cipolleschi in 4f732ba. When will my fix make it into a release? | Upcoming Releases |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff moves another part of the utilities from the
react_native_podsfile to a specificutils.rbfile.It adds tests for these utils and improve our test mocks.
The goal is to simplify the
react_native_pods.rbso it's easier to work with it.I decided to split this diff in 2 because it was becoming quite big.
Changelog
[iOS][Changed] - Refactoring part of the react_native_pods.rb script
Differential Revision: D37006265