Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Main][Windows] Working around Long paths limitation on Windows #33784

Closed
wants to merge 4 commits into from

Conversation

mganandraj
Copy link
Contributor

Cherry picking #33707 to main branch

This change is extending the changes made by alespergl to reduce the file paths and command lengths of ndk build commands
Essentially we are shortening the length of the source files by using relative paths instead of absolute paths as enumerated by the wildcard expression
This commit is extending the fix by including all the new modules introduced into RN for the new architecture, including the generated modules.
We are also reverting the ndk bump as ndk23 is crashing frequently when building RN with new arch. The reduced file paths lengths ensures the ndk bump is not required for relatively short application paths.

Summary

Fix building RN with new architecture on Windows boxes by using relative paths for C++ sources

Changelog

Fix building RN with new architecture on Windows boxes by using relative paths for C++ sources

[CATEGORY] [TYPE] - Message

Test Plan

Verified building on windows box

mganandraj and others added 4 commits May 5, 2022 13:41
…file paths and command lengths of ndk build commands

Essentially we are shortening the length of the source files by using relative paths instead of absolute paths as enumerated by the wildcard expression
This commit is extending the fix by including all the new modules introduced into RN for the new architecture, including the generated modules.
Co-authored-by: Aleš Pergl <alespergl@users.noreply.github.com>
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels May 8, 2022
@pull-bot
Copy link

pull-bot commented May 8, 2022

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against e1fb3ad

@mganandraj mganandraj changed the title Long paths2 [Main][Windows] Working around Long paths limitation on Windows May 8, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,794,509 -838
android hermes armeabi-v7a 7,196,935 -899
android hermes x86 8,104,063 -895
android hermes x86_64 8,083,563 -890
android jsc arm64-v8a 9,667,156 -841
android jsc armeabi-v7a 8,438,352 -898
android jsc x86 9,617,315 -912
android jsc x86_64 10,214,017 -892

Base commit: 23a160e
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 23a160e
Branch: main

@kelset kelset requested a review from cortinico May 9, 2022 09:01
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mganandraj in 883a938.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 9, 2022
@cortinico
Copy link
Contributor

Thanks again for doing this amazing work and sending this over @mganandraj 🙏

leotm added a commit to leotm/react-native-template-new-architecture that referenced this pull request May 13, 2022
leotm added a commit to leotm/react-native-template-new-architecture that referenced this pull request May 13, 2022
* Update react-native monorepo

* Upgrade to RN pods from 0.69.0-rc0 to rc1

* Revert Windows NDK 23 bump

Ref: facebook/react-native#33784

* Update Xcode config diffs

Ref: facebook/react-native@6efb517 (pbxproj)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
leotm added a commit to leotm/react-native-template-new-architecture that referenced this pull request May 13, 2022
* Update react-native monorepo

* Upgrade to RN pods from 0.69.0-rc0 to rc1

* Revert Windows NDK 23 bump

Ref: facebook/react-native#33784

* Update Xcode config diffs

Ref: facebook/react-native@6efb517 (pbxproj)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants