Update XMLHttpRequest.getAllResponseHeaders() implementation (#32353) #32363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eHeaders() (facebook#32353) As per the XMLHttpRequest specification [1], getAllResponseHeaders() should return a string of headers with lowercased names and sorted by their uppercase representation, with each header ending with '\r\n'. [1] https://xhr.spec.whatwg.org/#the-getallresponseheaders()-method
react-native-bot
added
the
No CLA
facebook-github-bot
added
CLA Signed
react-native-bot
removed
the
No CLA
|
@sota000 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
yungsters
requested changes
Oct 13, 2021
Libraries/Network/XMLHttpRequest.js
Outdated
| }); | ||
|
|
||
| // Sort in ascending order, with a being less than b if a's name is legacy-uppercased-byte less than b's name. | ||
| combinedHeaders.sort((a, b) => { |
There was a problem hiding this comment.
Why can't you use headerA.toUpperCase() < headerB.toUppercase()?
There was a problem hiding this comment.
Totally did not realize that'd accomplish the same thing!
When I was initially writing this I was worried about repeatedly uppercasing the whole string during each comparison. I did a quick benchmark and looks like your suggestion performs better, especially if we pre-compute the upper cased header once.
Co-authored-by: Timothy Yung <yungsters@gmail.com>
Create an object that contains the lower cased, upper cased, and value for each header during the combination step. The upper cased value is computed once to avoid re-computing it during sort().
ascherkus
commented
Oct 14, 2021
|
@sota000 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per the XMLHttpRequest specification [1], getAllResponseHeaders() should return a string of headers with lowercased names and sorted by their uppercase representation, with each header ending with '\r\n'.
[1] https://xhr.spec.whatwg.org/#the-getallresponseheaders()-method
Changelog
[General] [Changed] XMLHttpRequest.getAllResponseHeaders() now returns headers with names lowercased and sorted in ascending order, as per specification
Test Plan
Test derived from Web Platform Test repository:
https://github.com/web-platform-tests/wpt/tree/master/xhr