Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent native blob resource from being de-allocated prematurely #31392

Closed
wants to merge 2 commits into from
Closed

Prevent native blob resource from being de-allocated prematurely #31392

wants to merge 2 commits into from

Commits on Dec 5, 2022

  1. Prevent native blob resource from being de-allocated prematurely 

    Since `blob.slice()` creates a new view onto the same binary
data as the original blob, we should re-use the same collector
object so that the underlying resource gets deallocated when
the last view into the data is released, not the first.
    @awinograd @cortinico
    awinograd authored and cortinico committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    f1420ce View commit details
    Browse the repository at this point in the history

  2. fix trailing spacing

    @awinograd @cortinico
    awinograd authored and cortinico committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    d064dfe View commit details
    Browse the repository at this point in the history