[Android] onKeyPress event not fired with numeric keys #29046

fabOnReact · 2020-06-03T18:24:45Z

Summary

This issue fixes #19507 fixes #30475 onKeyPress event not fired for numeric keyboard
The TextInput onKeyPress event is not fired when pressing numeric keys on Android.

The method sendKeyEvent will dispatchKeyEvent only for:

ENTER_KEY_VALUE
KEYCODE_DEL (delete key)

The solution proposed is trigger dispatchKeyEvent for KeyEvents with event.getUnicodeChar() value included between 47 and 58 (numeric keys 0-9)

Changelog

[Android] [Fixed] - onKeyPress event not fired with numeric keys

Test Plan

CLICK TO OPEN TESTS RESULTS

BEFORE	AFTER

analysis-bot · 2020-06-03T18:42:00Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,891,121	+44
android	hermes	armeabi-v7a	8,394,854	+55
android	hermes	x86	9,380,376	+46
android	hermes	x86_64	9,323,109	+51
android	jsc	arm64-v8a	10,341,100	+49
android	jsc	armeabi-v7a	9,827,929	+53
android	jsc	x86	10,391,872	+59
android	jsc	x86_64	10,974,847	+56

Base commit: 4324ca8

analysis-bot · 2020-06-03T18:44:41Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 4324ca8

nukemonk · 2020-11-21T13:45:37Z

Thank you very much for this fix! There's only one adjustment that needs to be made on line 135:

boolean isNumberKey = event.getUnicodeChar() < 56 &&

the number needs to be < 58 since event.key for the number 9 is 57. Now number 8 and 9 are excluded and don't trigger the event.

fabOnReact · 2020-11-30T17:06:05Z

@nukemonk thanks a lot for the correction, I will make the adjustment this weekend. I wish you a good day. Fabrizio

facebook#29046 (comment)

analysis-bot

Code analysis results:

google-java-format found some issues. See https://github.com/google/google-java-format

analysis-bot · 2020-12-20T15:55:27Z

...id/src/main/java/com/facebook/react/views/textinput/ReactEditTextInputConnectionWrapper.java

@@ -132,10 +132,14 @@ public boolean deleteSurroundingText(int beforeLength, int afterLength) {
  @Override
  public boolean sendKeyEvent(KeyEvent event) {
    if (event.getAction() == KeyEvent.ACTION_DOWN) {
+      boolean isNumberKey = event.getUnicodeChar() < 58 &&


google-java-format suggested changes:

@@ -135,2 +135 @@ - boolean isNumberKey = event.getUnicodeChar() < 58 && - event.getUnicodeChar() > 47; + boolean isNumberKey = event.getUnicodeChar() < 58 && event.getUnicodeChar() > 47;

mariomurrent-softwaresolutions · 2020-12-21T17:32:51Z

Any Updates on this one?

fabOnReact · 2020-12-26T16:31:34Z

@mariomurrent-softwaresolutions I need more time and have more detailed look at the detox failures. Thanks

test-android

+ buck fetch ReactAndroid/src/test/java/com/facebook/react/modules
Not using buckd because watchman isn't installed.
Picked up _JAVA_OPTIONS: -XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap
PARSING BUCK FILES: FINISHED IN 1.9s
Buck wasn't able to parse /root/react-native/ReactAndroid/src/main/java/com/facebook/BUCK:
Incorrect arguments to android_library with name yoga: Extra unknown kwargs: autoglob

This error happened while trying to get dependency '//ReactAndroid/src/main/java/com/facebook:yoga' of target '//ReactAndroid/src/test/java/com/facebook/react/modules:modules'

Exited with code exit status 1

test-docker

Not using buckd because watchman isn't installed.
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
PARSING BUCK FILES: FINISHED IN 3.3s
Buck wasn't able to parse /app/ReactAndroid/src/main/java/com/facebook/BUCK:
Incorrect arguments to android_library with name yoga: Extra unknown kwargs: autoglob

This error happened while trying to get dependency '//ReactAndroid/src/main/java/com/facebook:yoga' of target '//ReactAndroid/src/test/java/com/facebook/react/modules:modules'
The command '/bin/sh -c buck fetch ReactAndroid/src/test/java/com/facebook/react/modules' returned a non-zero code: 1
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Exited with code exit status 1

CircleCI received exit code 1

mariomurrent-softwaresolutions · 2020-12-26T16:32:50Z

Okay, cool & thx

mariomurrent-softwaresolutions · 2021-01-02T16:08:03Z

@fabriziobertoglio1987 Is it done?

vadimb · 2021-01-05T14:11:38Z

@fabriziobertoglio1987 this CI's issue you are experiencing seems to have been fixed in master. Would you mind updating your branch to master please? I'm more then happy to collaborate on this if you are busy.

fabOnReact · 2021-01-05T17:29:36Z

@vadimb thanks a lot for your feedback. Feel free to do a code review on this pr and collaborate with me. I'll be happy to accept your improvements.. Currently I'm working (in my free time) on other prs and I don't know of any problems with this pr, but I'll be happy to follow your advice/improvements. Thanks a lot for finding the solution to the issue with CI Tests. Thanks a lot 🙏

vadimb · 2021-01-10T15:24:56Z

~~@fabriziobertoglio1987 I just observed that you handle ONLY digits, right? So if I were to use a phone-pad typing on~~ ~~non-digit key like + e.g +1 123 123 1234 wont work( I'll get only the digits).~~

~~I'm wondering what keeps us from matching the iOS implementation https://github.com/facebook/reac~~
~~t-native/blob/master/React/CoreModules/RCTEventDispatcher.mm#L85 where all keys get pass trough ?~~

Just tested and seems all other keys(including +) are handled properly - so your fix seems right!

Hopefully it will land ASAP 👍

fabOnReact · 2021-01-10T16:51:55Z

thanks a lot @vadimb

yes, but still reading your review and interacting with you is very valuable for me, as from our interaction we may get ideas on how to improve or break this functionality.

I consider you comment a very valuable code review. I did not think about this scenario and use case, but luckily it was covered.
I wish you a good evening. Thanks. Fabrizio

vadimb · 2021-01-22T15:51:10Z

@nukemonk can you please let us know if there is any eta when we this PR will be merged?

fabOnReact · 2021-01-22T16:01:09Z

@vadimb there is no eta. 🙏 😄

nukemonk · 2021-01-22T16:01:58Z

@nukemonk can you please let us know if there is any eta when we this PR will be merged?

@vadimb I am sorry but I am unsure about what you request of me. I am not a maintainer of this branch nor I am authorized to do anything with it.

vadimb · 2021-01-22T16:03:24Z

My bad - seeing that you approved thought you have super powers :) - but seems anyone can review/approve.

mariomurrent-softwaresolutions · 2021-01-22T17:26:11Z

I already updated the code from @fabriziobertoglio1987. But no PR approve on his side

pepf

🥇

vastamaki · 2021-03-12T10:10:16Z

Any estimate when this could be released? 🙂

fabOnReact · 2021-03-12T10:28:28Z

@vastamaki you can check out https://github.com/sponsors/fabriziobertoglio1987 if you are interested, otherwise I can estimate 6-12 months.

fabOnReact · 2021-03-16T15:43:50Z

Any estimate when this could be released?

@vastamaki To answer the question of when this fix will be released in the next version of React Native, I suggest you to follow the discussions at https://github.com/react-native-community/releases/issues by subscribing to those threads. The process of releasing a new version with a bug fix is the following:

an Issue is opened in facebook/react-native
a contributor writes a Pull Request to fix/close the react-native Issue
once the Pull Request is merged, the issue is closed. The review and merge is performed by the Facebook Team that works on the Facebook Ads App running React Native from source. Currently we have 351 open pull requests so the review and merge may take some time.
The fix is tested in Facebook Ads App running React Native from master for several months
For each realease (the upcoming one is 0.64.1) there will be a separate discussion on https://github.com/react-native-community/releases/issues to discuss
In this discussion everyone can request a commit to be cherrypicked from master. The link need to be from the a commit from master (for ex. [Android] Adding Hyphenation Frequency prop for Text component #29157 (comment)) and not a Pull Request not yet merged in master ☮️ 🙏

lfabl · 2021-04-13T23:11:38Z

Same problem. But not only android. My problem on both. ( IOS + Android ). I don't know why pull request was technically rejected, but I have a specific need. I am faced with a case that works according to an algorithm and I have to process individual letters. Just; numbers, commas, periods and backspace. For this reason, is it possible to come up with a solution?

facebook-github-bot · 2021-08-19T16:22:26Z

@sshic has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-08-19T16:23:25Z

@sshic has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-08-25T11:57:22Z

@sshic merged this pull request in ee3e71f.

Matiassimone · 2022-08-08T19:50:03Z

Still persists,
on "react-native": "0.68.2".

Using this TextInput with the follow props and keyboardType="number-pad",
the numbers only trigger in the onKeyPress,
onChangeText or onChange callbacks are NOT called when press numbers (1, 2, 3...).

      <TextInput
        autoFocus
        caretHidden
        contextMenuHidden
        onKeyPress={onKeyPress}
        ref={phoneRef}
        maxLength={6}
        autoCorrect={false}
        onChange={onChange}
        onChangeText={onChangeText}
        keyboardType="number-pad"
        textContentType="oneTimeCode"
        autoComplete="sms-otp"
        keyboardAppearance={isDarkMode ? 'dark' : 'light'}
        style={styles.nativeKeyboardHidden}
      />

log keypress events from numeric keys

bd52916

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2020

react-native-bot added Bug Platform: Android Android applications. labels Jun 3, 2020

fabOnReact changed the title ~~log keypress events from numeric keys~~ [Android] onKeyPress event not fired with numeric keys Jun 3, 2020

fabOnReact mentioned this pull request Jun 18, 2020

[Android] onKeyPress event not fired for numeric keyboard #19507

Closed

code review from https://github.com/nukemonk

76546b3

facebook#29046 (comment)

nukemonk approved these changes Dec 5, 2020

View reviewed changes

fabOnReact marked this pull request as draft December 7, 2020 08:13

Merge branch 'master' into numpad-keypress-not-logging

df7d841

fabOnReact marked this pull request as ready for review December 20, 2020 15:45

analysis-bot suggested changes Dec 20, 2020

View reviewed changes

analysis-bot - google-java-format issue

a9f8616

fabOnReact closed this Jan 2, 2021

fabOnReact deleted the numpad-keypress-not-logging branch January 2, 2021 15:52

fabOnReact restored the numpad-keypress-not-logging branch January 2, 2021 15:52

fabOnReact reopened this Jan 3, 2021

Merge branch 'master' into numpad-keypress-not-logging

564762a

vadimb approved these changes Jan 22, 2021

View reviewed changes

fabOnReact added 2 commits January 25, 2021 09:18

Merge branch 'master' into numpad-keypress-not-logging

2d26997

Merge branch 'master' into numpad-keypress-not-logging

169cc54

msegers approved these changes Mar 5, 2021

View reviewed changes

pepf approved these changes Mar 5, 2021

View reviewed changes

fabOnReact mentioned this pull request Mar 16, 2021

Android TextInput onKeyPress not fired #30475

Closed

matt-oakes mentioned this pull request Aug 19, 2021

Upcoming v0.65.1 cherrypicks discussion react-native-community/releases#244

Closed

kelset added the Needs: React Native Team Attention label Aug 19, 2021

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 19, 2021

facebook-github-bot closed this in ee3e71f Aug 25, 2021

facebook-github-bot added the Merged This PR has been merged. label Aug 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] onKeyPress event not fired with numeric keys #29046

[Android] onKeyPress event not fired with numeric keys #29046

fabOnReact commented Jun 3, 2020 •

edited

Loading

analysis-bot commented Jun 3, 2020 •

edited

Loading

analysis-bot commented Jun 3, 2020 •

edited

Loading

nukemonk commented Nov 21, 2020 •

edited

Loading

fabOnReact commented Nov 30, 2020

analysis-bot left a comment

analysis-bot Dec 20, 2020

mariomurrent-softwaresolutions commented Dec 21, 2020

fabOnReact commented Dec 26, 2020

mariomurrent-softwaresolutions commented Dec 26, 2020

mariomurrent-softwaresolutions commented Jan 2, 2021

vadimb commented Jan 5, 2021

fabOnReact commented Jan 5, 2021 •

edited

Loading

vadimb commented Jan 10, 2021 •

edited

Loading

fabOnReact commented Jan 10, 2021

vadimb commented Jan 22, 2021

fabOnReact commented Jan 22, 2021 •

edited

Loading

nukemonk commented Jan 22, 2021

vadimb commented Jan 22, 2021

mariomurrent-softwaresolutions commented Jan 22, 2021

pepf left a comment

vastamaki commented Mar 12, 2021

fabOnReact commented Mar 12, 2021

fabOnReact commented Mar 16, 2021

lfabl commented Apr 13, 2021

facebook-github-bot commented Aug 19, 2021

facebook-github-bot commented Aug 19, 2021

facebook-github-bot commented Aug 25, 2021

Matiassimone commented Aug 8, 2022

[Android] onKeyPress event not fired with numeric keys #29046

[Android] onKeyPress event not fired with numeric keys #29046

Conversation

fabOnReact commented Jun 3, 2020 • edited Loading

Summary

Changelog

Test Plan

analysis-bot commented Jun 3, 2020 • edited Loading

analysis-bot commented Jun 3, 2020 • edited Loading

nukemonk commented Nov 21, 2020 • edited Loading

fabOnReact commented Nov 30, 2020

analysis-bot left a comment

Choose a reason for hiding this comment

analysis-bot Dec 20, 2020

Choose a reason for hiding this comment

mariomurrent-softwaresolutions commented Dec 21, 2020

fabOnReact commented Dec 26, 2020

mariomurrent-softwaresolutions commented Dec 26, 2020

mariomurrent-softwaresolutions commented Jan 2, 2021

vadimb commented Jan 5, 2021

fabOnReact commented Jan 5, 2021 • edited Loading

vadimb commented Jan 10, 2021 • edited Loading

fabOnReact commented Jan 10, 2021

vadimb commented Jan 22, 2021

fabOnReact commented Jan 22, 2021 • edited Loading

nukemonk commented Jan 22, 2021

vadimb commented Jan 22, 2021

mariomurrent-softwaresolutions commented Jan 22, 2021

pepf left a comment

Choose a reason for hiding this comment

vastamaki commented Mar 12, 2021

fabOnReact commented Mar 12, 2021

fabOnReact commented Mar 16, 2021

lfabl commented Apr 13, 2021

facebook-github-bot commented Aug 19, 2021

facebook-github-bot commented Aug 19, 2021

facebook-github-bot commented Aug 25, 2021

Matiassimone commented Aug 8, 2022

fabOnReact commented Jun 3, 2020 •

edited

Loading

analysis-bot commented Jun 3, 2020 •

edited

Loading

analysis-bot commented Jun 3, 2020 •

edited

Loading

nukemonk commented Nov 21, 2020 •

edited

Loading

fabOnReact commented Jan 5, 2021 •

edited

Loading

vadimb commented Jan 10, 2021 •

edited

Loading

fabOnReact commented Jan 22, 2021 •

edited

Loading