Rename autolinking-ios.rb script and bring RNTester and template in line. #28077
Conversation
alloy
changed the title
facebook-github-bot
added
the
CLA Signed
|
RNTester (Android/hermes/arm64-v8a): 3289088 bytes |
|
RNTester.app (iOS): 10657792 bytes |
|
@TheSavior bump |
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for the bump. Can you rebase this? I'm getting merge conflicts |
“autlinking” is a CLI feature where 3rd-party pods are automatically discovered: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
This is what is already being used on CI implicitly
alloy
force-pushed
the
ios-link-rn-pods-improvements
branch
from
9c88fc6
to
5fca5cf
Compare
|
Done ✅ |
|
RNTester (Android/hermes/arm64-v8a): 3289088 bytes |
|
RNTester.app (iOS): 10657792 bytes |
There was a problem hiding this comment.
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @alloy in 4118d79. When will my fix make it into a release? | Upcoming Releases |
…ine. (facebook#28077) Summary: Make the script ready for picking in 0.62.0-rc.3. * Rename the script to remove ambiguity. “autolinking” is a CLI feature where 3rd-party pods are automatically discovered: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md * Make the Flipper version of the pods configurable, as requested [here](facebook#28044 (comment)). * Make RNTester’s Podfile use the same form as the template–including enabling Flipper by moving the CPP define into the right place in the Xcode project and out of the Podfile. * Get rid of Podfile.lock thrashing by making the default CDN spec source explicit. ## Changelog [iOS] [Changed] - Disambiguate autolinking-ios.rb script from CLI’s “autolinking” feature and bring RNTester & template in line. Pull Request resolved: facebook#28077 Test Plan: RNTester builds, as does a new application. Reviewed By: PeteTheHeat Differential Revision: D19956392 Pulled By: TheSavior fbshipit-source-id: 6c800ddb646b49fc45c088978e2794cd7b60ea48
Summary
Make the script ready for picking in 0.62.0-rc.3.
Changelog
[iOS] [Changed] - Disambiguate autolinking-ios.rb script from CLI’s “autolinking” feature and bring RNTester & template in line.
Test Plan
RNTester builds, as does a new application.