Remove DatePickerAndroid, DatePickerIOS, TimePickerAndroid #26729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
react-native-bot
added
API: DatePickerAndroid
API: TimePickerAndroid
Component: PickerIOS
Platform: Android
|
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
safaiyeh
changed the title
|
Notes about the failing tests:
cc: @cpojer |
|
Thank you for sending this PR. Unfortunately these removals can only be done in stages from someone at fb so I’ll have to close this. I’ll use your PR as a starting point for when I’m going to make that migration :) |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 26, 2023
Summary: I found a couple scenarios where preloads were issued too aggressively 1. During SSR, if you render a new stylesheet after the preamble flushed it will flush a preload even if the resource was already preloaded 2. During Client render, if you call `ReactDOM.preload()` it will only check if a preload exists in the Document before inserting a new one. It should check for an underlying resource such as a stylesheet link or script if the preload is for a recognized asset type DiffTrain build for commit facebook/react@ec5e9c2. Reviewed By: kassens Differential Revision: D45295400 fbshipit-source-id: 6255a2c72d321fdef508d8805b3a5cb807c5c384
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: I found a couple scenarios where preloads were issued too aggressively 1. During SSR, if you render a new stylesheet after the preamble flushed it will flush a preload even if the resource was already preloaded 2. During Client render, if you call `ReactDOM.preload()` it will only check if a preload exists in the Document before inserting a new one. It should check for an underlying resource such as a stylesheet link or script if the preload is for a recognized asset type DiffTrain build for commit facebook/react@ec5e9c2. Reviewed By: kassens Differential Revision: D45295400 fbshipit-source-id: 6255a2c72d321fdef508d8805b3a5cb807c5c384
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: I found a couple scenarios where preloads were issued too aggressively 1. During SSR, if you render a new stylesheet after the preamble flushed it will flush a preload even if the resource was already preloaded 2. During Client render, if you call `ReactDOM.preload()` it will only check if a preload exists in the Document before inserting a new one. It should check for an underlying resource such as a stylesheet link or script if the preload is for a recognized asset type DiffTrain build for commit facebook/react@ec5e9c2. Reviewed By: kassens Differential Revision: D45295400 fbshipit-source-id: 6255a2c72d321fdef508d8805b3a5cb807c5c384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #23313
Removed DatePickerAndroid, DatePickerIOS, TimePickerAndroid from react-native in favor for https://github.com/react-native-community/react-native-datetimepicker
Changelog
[General] [Removed] - Removed DatePickerAndroid, DatePickerIOS, TimePickerAndroid
Test Plan