-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(gradle): update build.gradle #25810
Conversation
Remove obsolete supportLibVersion - no longer required with AndroidX
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osdnk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Hope it won't break internals
This pull request was successfully merged by @ferdicus in fee7f06. When will my fix make it into a release? | Upcoming Releases |
Remove obsolete supportLibVersion - no longer required with AndroidX
Summary
Removing the
supportLibVersion
variable that was used inapp/build.gradle
to suffix version numbers on android support libraries.As react-native moved to androidX with the release of
0.60
this is no longer necessary.Changelog
[Android] [Removed] - Remove supportLibVersion variable in build.gradle
Test Plan
No tests were run locally