Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JSC to 245459.0.0 #25449

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jul 1, 2019

Summary

Upgrade bundled JSC to jsc-android@245459.0.0.
This PR is to address #24261 and specific for RN 0.59.
More details please refer to #25426

NOTE that this PR is branched from 0.59-stable and should be merged or cherry-picked into 0.59-stable branch only.

Changelog

[Android] [Fixed] - Upgrade jsc-android to r245459 and fix crash on Samsung S7 Edge

Test Plan

  1. Test ./gradlew clean :ReactAndroid:installArchives and unzip generated android/com/facebook/react/react-native/0.59.9/react-native-0.59.9.aar.
    Use strings jni/arm64-v8a/libjsc.so | grep -C 1 JavaScriptCore.Version to verify the output should be something like
API Wrapper
JavaScriptCore.Version
245459.0.0
  1. Initiate a RN059 project but build from sources with this patch. Verify application runs without problem and will have 245459.0.0 in adb logcat output.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Jul 1, 2019
@pull-bot
Copy link

pull-bot commented Jul 1, 2019

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS against 65a2f38

@react-native-bot react-native-bot added Bug Platform: Android Android applications. labels Jul 1, 2019
@fjmorant
Copy link

fjmorant commented Jul 1, 2019

👍

@kelset kelset merged commit 557989a into facebook:0.59-stable Jul 1, 2019
jakubgs pushed a commit to status-im/react-native that referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants