Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[template] Implement changes to enable native modules auto linking #24506

Closed
wants to merge 8 commits into from

Conversation

Salakar
Copy link
Contributor

@Salakar Salakar commented Apr 18, 2019

Summary

Replaces #24099 (original PR became detached for some reason)

Implements the template changes required to enable native modules auto-linking for both Android & iOS.

Requires the following to be merged first and an updated CLI to be published:

cc @grabbou @thymikee @orta for review

Depends on

Changelog

[TEMPLATE] [FEATURE] - Enable auto-initialization/linking of react native modules for new projects

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2019
@Salakar Salakar changed the title [template] Implement changes to enable native modules auto linking [wip][template] Implement changes to enable native modules auto linking Apr 18, 2019
@pull-bot
Copy link

pull-bot commented Apr 18, 2019

Messages
📖

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 7a90b84

@Salakar Salakar self-assigned this Apr 18, 2019
@Salakar Salakar added Platform: Android Android applications. Platform: iOS iOS applications. labels Apr 18, 2019
@Salakar Salakar changed the title [wip][template] Implement changes to enable native modules auto linking [template] Implement changes to enable native modules auto linking Apr 22, 2019
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. Autolinking FTW.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Salakar in 261197d.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 24, 2019
facebook-github-bot pushed a commit that referenced this pull request May 13, 2019
Summary:
The iOS End-to-End tests started failing with the updates made to the iOS template's Podfile in 261197d. Undoing these gets our CI iOS e2e test step back to green.

[iOS] [Removed] - Revert auto-linking related changes to the iOS template Podfile
Pull Request resolved: #24788

Differential Revision: D15317895

Pulled By: cpojer

fbshipit-source-id: a1f3b84b39c6d341740f742d83fd05a1ab841184
kelset pushed a commit that referenced this pull request Jun 19, 2019
Summary:
Replaces #24099 (original PR became detached for some reason)

Implements the template changes required to enable native modules auto-linking for both Android & iOS.

Requires the following to be merged first and an updated CLI to be published:

- [x] react-native-community/cli#254
- [x] react-native-community/cli#256
- [x] react-native-community/cli#258

cc grabbou thymikee orta for review

- [ ] #24517 update CLI version)

[TEMPLATE] [FEATURE] - Enable auto-initialization/linking of react native modules for new projects
Pull Request resolved: #24506

Differential Revision: D15062701

Pulled By: cpojer

fbshipit-source-id: 65296cbec2925405fe8033de71910325e0c719bc

# Conflicts:
#	template/ios/Podfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: Linking CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants