Fix jsc regression.Fixes #22274 #22293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
gengjiawen
changed the title
gengjiawen
added
Platform: Android
hramos
reviewed
Nov 15, 2018
| @@ -324,7 +324,7 @@ dependencies { | |||
| api "com.squareup.okhttp3:okhttp:${OKHTTP_VERSION}" | |||
| api "com.squareup.okhttp3:okhttp-urlconnection:${OKHTTP_VERSION}" | |||
| api 'com.squareup.okio:okio:1.14.0' | |||
| compile project(':android-jsc') | |||
| compile 'org.webkit:android-jsc:r174650' | |||
Kudo
approved these changes
Nov 16, 2018
|
@Kudo Thanks for report and review this. |
This was referenced Nov 17, 2018
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 21, 2018
There was a problem hiding this comment.
@kelset is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@gengjiawen merged commit f22473e into |
grabbou
pushed a commit
that referenced
this pull request
Nov 22, 2018
Summary: My silly mistake when tinkering with the jsc lib. Also you have this patch first #22295. Kudo plz review.  Pull Request resolved: #22293 Differential Revision: D13153931 Pulled By: hramos fbshipit-source-id: 8a6efa0cd8abbff359f082d5ea7713933b6e7ac6
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: My silly mistake when tinkering with the jsc lib. Also you have this patch first facebook#22295. Kudo plz review.  Pull Request resolved: facebook#22293 Differential Revision: D13153931 Pulled By: hramos fbshipit-source-id: 8a6efa0cd8abbff359f082d5ea7713933b6e7ac6
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: My silly mistake when tinkering with the jsc lib. Also you have this patch first facebook#22295. Kudo plz review.  Pull Request resolved: facebook#22293 Differential Revision: D13153931 Pulled By: hramos fbshipit-source-id: 8a6efa0cd8abbff359f082d5ea7713933b6e7ac6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My silly mistake when tinkering with the jsc lib. Also you have this patch first #22295.
@Kudo plz review.