Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Flow strict mode on for Picker #22115

Closed
wants to merge 3 commits into from

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented Nov 4, 2018

Related to #22100

Turn Flow strict mode on for Libraries/Components/Picker/Picker.js

Test Plan:

  • npm run prettier
  • npm run flow-check-ios
  • npm run flow-check-android

This error was happend #22101 #22048

Release Notes:

[GENERAL] [ENHANCEMENT] [Libraries/Components/Picker/Picker.js] - Flow strict mode

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2018
@pull-bot
Copy link

pull-bot commented Nov 4, 2018

Warnings
⚠️

📋 Release Notes - This PR may have incorrectly formatted Release Notes.

Generated by 🚫 dangerJS

@nissy-dev
Copy link
Contributor Author

I got this error.... How shoud i do...? 🙇

// Importing from an untyped module makes it any and is not safe! Did you mean to add @flow to the top of PickerIOS? (untyped-import)
const PickerAndroid = require('PickerAndroid');
const PickerIOS = require('PickerIOS');

@elicwhite
Copy link
Member

You won't be able to turn on flow strict-local until those files are typed. I just wouldn't worry about switching this file over to strict-local for now and instead just leave it with @flow.

@nissy-dev nissy-dev closed this Nov 5, 2018
@elicwhite
Copy link
Member

What happened with this PR? Did you intend to close it?

@nissy-dev
Copy link
Contributor Author

nissy-dev commented Nov 5, 2018

@TheSavior
I'm so sorry for no comment🙇
I resubmit this PR #22128, please check!

@nissy-dev
Copy link
Contributor Author

Deprecated #22128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants