[FlowCleanup] Split ImageProps into DeprecatedPropTypes #21411
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| /** | ||
| * See https://facebook.github.io/react-native/docs/image.html#style | ||
| */ | ||
| style: DeprecatedStyleSheetPropType(DeprecatedImageStylePropTypes), |
There was a problem hiding this comment.
In general, we should have a singular source of truth for the documentation, which should be the flow types. So, could you move these comments to the ImageProps flow type?
There was a problem hiding this comment.
While moving comments over, I noticed a few discrepancies between Flow properties and propType properties. The following are declared as propTypes (in DeprecatedImageProps, soon to be renamed DeprecatedImagePropType) but not in Flow (in ImageProps):
- accessible: PropTypes.bool
- accessibilityLabel: PropTypes.node
- resizeMode: PropTypes.oneOf([
'cover',
'contain',
'stretch',
'repeat',
'center',
]) - testID: PropTypes.string
- onLayout: PropTypes.func
Are these not needed in the Flow definitions, or are they missing from the Flow definitions? If they're not needed, what should I do with their corresponding comments? Delete them?
There was a problem hiding this comment.
Oh, interesting. We should move these properties to the flow definitions.
There was a problem hiding this comment.
Turns out resizeMode was already there, I missed it my first go around. The other 4 weren't though, so I added them.
hramos
changed the title
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@JenLindsay merged commit 408207b into |
Summary: Related to facebook#21342 - Split ImageProps.js: moved propType declarations to DeprecatedImageProps.js - Renamed ImageProps references to DeprecatedImageProps in Image.ios.js Pull Request resolved: facebook#21411 Reviewed By: TheSavior Differential Revision: D10146178 Pulled By: RSNara fbshipit-source-id: 4db15eaaa8822e834af347d1927991dff1c427cb
Related to #21342
Test Plan:
Ran the following scripts with no errors:
npm run prettiernpm run flow-check-iosnpm run flow-check-androidRelease Notes:
[GENERAL] [ENHANCEMENT] [ImageProps.js] - rm prop-types
[GENERAL] [ENHANCEMENT] [DeprecatedImageProps.js] - created file & added prop-types
[GENERAL] [ENHANCEMENT] [Image.ios.js] - renamed ImageProps to DeprecatedImageProps
This is my first PR, please let me know if I've done anything incorrectly - thanks!