Move and Rename propType definitions in ShadowPropTypesIOS #21379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Looks like you have a merge conflict. ColorPropType was changed to DeprecatedColorPropType in another commit. |
|
@TheSavior, just updated the PR. Sorry about that. 🤖 |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 28, 2018
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
No problem, not your fault. Just a race condition from landing the other one first. Thanks for updating and thanks for contributing! |
|
@gvarandas merged commit f94d2ad into Once this commit is added to a release, you will see the corresponding version tag below the description at f94d2ad. If the commit has a single |
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…21379) Summary: related facebook#21342 move TransformPropTypes.js fix flow error - [x] yarn prettier - [x] yarn flow-check-android - [x] yarn flow-check-ios All flow checks pass. [GENERAL] [ENHANCEMENT] [DeprecatedShadowPropTypesIOS.js] - Created. Pull Request resolved: facebook#21379 Differential Revision: D10098750 Pulled By: TheSavior fbshipit-source-id: f7f2e4bf7b837c00a14b1fbd930d1b29ffb63549
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #21342
TODO
move TransformPropTypes.js
fix flow error
CheckList
Test Plan
All flow checks pass.
Release Notes
[GENERAL] [ENHANCEMENT] [DeprecatedShadowPropTypesIOS.js] - Created.