-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PropTypes -> Flow] TVViewPropTypes, PlatformViewPropTypes, ViewStylePropTypes #21352
Conversation
Thanks for contributing this so far! It looks like you have some merge conflicts as ViewPropTypes was already split in this commit: 1b90908. Can you rebase on master? |
Looks like you still have conflicts and somehow yoga changes got included in your commits. :) |
Are you going to redo this as a new pull request? |
Yep, I'm cleaning it, it was conflicting with Yoga and other things, push should come soon soon ;) |
I made a new PR (sorry for the mess...) |
Related to #21342
Test Plan:
All flow tests succeed.
Release Notes:
[GENERAL] [ENHANCEMENT] [TVViewPropTypes.js] - rm prop-types
[GENERAL] [ENHANCEMENT] [PlatformViewPropTypes.android.js] - replace prop-types by Flow
[GENERAL] [ENHANCEMENT] [PlatformViewPropTypes.ios.js] - replace prop-types by Flow
[GENERAL] [ENHANCEMENT] [ViewPropTypes.js] - replace PlatformViewPropTypes import by Flow. Prop-type has to be splitted.
[GENERAL] [ENHANCEMENT] [DeprecatedTVViewPropTypes.js] - old prop-types