Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PropTypes -> Flow] TVViewPropTypes, PlatformViewPropTypes, ViewStylePropTypes #21352

Closed
wants to merge 0 commits into from
Closed

[PropTypes -> Flow] TVViewPropTypes, PlatformViewPropTypes, ViewStylePropTypes #21352

wants to merge 0 commits into from

Conversation

exced
Copy link
Contributor

@exced exced commented Sep 27, 2018 •
edited
Loading

Related to #21342

  • Split TVViewPropTypes
  • PlatformViewPropTypes (dependencies) flow types and old prop-type definitions
  • ViewStylePropTypes (dependencies) rm prop-type

Test Plan:

All flow tests succeed.

Release Notes:

[GENERAL] [ENHANCEMENT] [TVViewPropTypes.js] - rm prop-types
[GENERAL] [ENHANCEMENT] [PlatformViewPropTypes.android.js] - replace prop-types by Flow
[GENERAL] [ENHANCEMENT] [PlatformViewPropTypes.ios.js] - replace prop-types by Flow
[GENERAL] [ENHANCEMENT] [ViewPropTypes.js] - replace PlatformViewPropTypes import by Flow. Prop-type has to be splitted.
[GENERAL] [ENHANCEMENT] [DeprecatedTVViewPropTypes.js] - old prop-types

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2018
@exced exced changed the title Split TVViewPropTypes Split TVViewPropTypes, PlatformViewPropTypes Sep 27, 2018
@exced exced changed the title Split TVViewPropTypes, PlatformViewPropTypes [PropTypes -> Flow] TVViewPropTypes, PlatformViewPropTypes Sep 27, 2018
@react-native-bot react-native-bot added 🔶Components Missing Test Plan This PR appears to be missing a test plan. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Sep 27, 2018
@exced exced changed the title [PropTypes -> Flow] TVViewPropTypes, PlatformViewPropTypes [PropTypes -> Flow] TVViewPropTypes, PlatformViewPropTypes, ViewStylePropTypes Sep 27, 2018
@react-native-bot react-native-bot added ✅Release Notes and removed Missing Test Plan This PR appears to be missing a test plan. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Sep 27, 2018
@elicwhite
Copy link
Member

Thanks for contributing this so far! It looks like you have some merge conflicts as ViewPropTypes was already split in this commit: 1b90908. Can you rebase on master?

@elicwhite
Copy link
Member

Looks like you still have conflicts and somehow yoga changes got included in your commits. :)

@exced exced closed this Sep 27, 2018
@empyrical
Copy link
Contributor

Are you going to redo this as a new pull request?

@exced
Copy link
Contributor Author

exced commented Sep 27, 2018

Yep, I'm cleaning it, it was conflicting with Yoga and other things, push should come soon soon ;)

@exced
Copy link
Contributor Author

exced commented Sep 27, 2018

I made a new PR (sorry for the mess...)
#21372
There's now a lot of conflicts with the new ViewPropTypes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicwhite elicwhite elicwhite left review comments

@empyrical empyrical empyrical left review comments

@eslint-bot eslint-bot eslint-bot left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@exced @elicwhite @empyrical @eslint-bot @facebook-github-bot @react-native-bot