Picker: Remove PropTypes #21281
Closed
Picker: Remove PropTypes #21281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
elicwhite
requested changes
Sep 24, 2018
| >; | ||
|
|
||
| type PickerAndroidProps = $ReadOnly<{| | ||
| children?: ?React.Node, |
There was a problem hiding this comment.
React.Node includes null
children?: React.Node
| render() { | ||
| // The items are not rendered directly | ||
| throw null; | ||
| } | ||
| } | ||
|
|
||
| type PickerProps = $ReadOnly<{| | ||
| children?: ?React.Node, |
elicwhite
approved these changes
Sep 24, 2018
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@empyrical merged commit 421667c into Once this commit is added to a release, you will see the corresponding version tag below the description at 421667c. If the commit has a single |
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Part of: react-native-community/discussions-and-proposals#29 This pull request removes all PropTypes from the various files for `Picker` and cleans up their flow types. Pull Request resolved: facebook#21281 Differential Revision: D10007224 Pulled By: TheSavior fbshipit-source-id: 5b8b7918cc918dd77e7ab27c9e3921ffbeb4ff73
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: react-native-community/discussions-and-proposals#29
This pull request removes all PropTypes from the various files for
Pickerand cleans up their flow types.Test Plan:
flow checkandflow check --flowconfig-name .flowconfig.androidboth passRelease Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[GENERAL] [ENHANCEMENT] [Libraries/Components/Picker/Picker.js] - Removed all PropTypes
[GENERAL] [ENHANCEMENT] [Libraries/Components/Picker/PickerAndroid.android.js] - Removed all PropTypes