Hotfix to include react-native-windows in hasteImpl accepted paths #20007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
…acebook#20007) Summary: Closes facebook#20007 We removed support for providesModule annotations and maintained support for Haste names in installed modules via `providesModuleNodeModules`, but our default `hasteImpl` doesn't take them into account. We need to find a better way to override core components from plugins but meanwhile this adds an exception for react-native-windows in the default `hasteImpl` to unblock their upgrade to the latest RC. Fixes facebook/metro#188 Reviewed By: mjesun Differential Revision: D8695207 fbshipit-source-id: e70c8649543ebfcba40f934451faf33548c3d20a
react-native-bot
added
Missing Test Plan
|
Test passed. Closing. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2018
…20007) Summary: Closes #20007 We removed support for providesModule annotations and maintained support for Haste names in installed modules via `providesModuleNodeModules`, but our default `hasteImpl` doesn't take them into account. We need to find a better way to override core components from plugins but meanwhile this adds an exception for react-native-windows in the default `hasteImpl` to unblock their upgrade to the latest RC. Fixes facebook/metro#188 Reviewed By: mjesun Differential Revision: D8695207 fbshipit-source-id: 2ad6cb1e93e600880a148776ac45f6ebd7d205d3
|
This pull request was closed by @rubennorte in 5494274. Once this commit is added to a release, you will see the corresponding version tag below the description at 5494274. If the commit has a single |
hramos
pushed a commit
that referenced
this pull request
Jul 4, 2018
…20007) Summary: Closes #20007 We removed support for providesModule annotations and maintained support for Haste names in installed modules via `providesModuleNodeModules`, but our default `hasteImpl` doesn't take them into account. We need to find a better way to override core components from plugins but meanwhile this adds an exception for react-native-windows in the default `hasteImpl` to unblock their upgrade to the latest RC. Fixes facebook/metro#188 Reviewed By: mjesun Differential Revision: D8695207 fbshipit-source-id: 2ad6cb1e93e600880a148776ac45f6ebd7d205d3
|
Thanks @hramos - what's the status update on a generalization of this? I still need a solution for the |
|
cc @rubennorte, original author of the diff that synced out as 5494274. |
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
…20007) Summary: Closes facebook/react-native#20007 We removed support for providesModule annotations and maintained support for Haste names in installed modules via `providesModuleNodeModules`, but our default `hasteImpl` doesn't take them into account. We need to find a better way to override core components from plugins but meanwhile this adds an exception for react-native-windows in the default `hasteImpl` to unblock their upgrade to the latest RC. Fixes facebook/metro#188 Reviewed By: mjesun Differential Revision: D8695207 fbshipit-source-id: 2ad6cb1e93e600880a148776ac45f6ebd7d205d3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We removed support for providesModule annotations and maintained support for Haste names in installed modules via
providesModuleNodeModules, but our defaulthasteImpldoesn't take them into account. We need to find a better way to override core components from plugins but meanwhile this adds an exception for react-native-windows in the defaulthasteImplto unblock their upgrade to the latest RC.Fixes facebook/metro#188
Reviewed By: mjesun
Differential Revision: D8695207