Update fresco to v1.9.0, okhttp3 to v3.10.0 #18849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: fresco v1.9.0 updated to MIT license, fixed WebP native memory leak bug which caused android app crash.
facebook-github-bot
added
the
CLA Signed
|
@mdvacca Wanna try landing in case some other things need to be updated @ fb |
There was a problem hiding this comment.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@janicduplessis @mdvacca Why has this not merged to the master yet？ Is something wrong with internal import system ？ |
facebook-github-bot
added
the
Import Started
|
@gengjiawen Probably needed some changes to update fb internal dependencies, it just landed now! |
|
Thanks. |
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: I found many crash reports of imagepipeline in our android app, this is caused by fresco webp native memory leak, they have fixed it in v1.9.0 fixed wrong pull request of [18848](facebook#18848) Test with local build. Check CI passes. [ANDROID] [ENHANCEMENT] [Fresco/OkHttp] - Updates Fresco to 1.9.0, OkHttp to 3.10.0 Closes facebook#18849 Differential Revision: D7651377 Pulled By: mdvacca fbshipit-source-id: 0bfe79fd3d232b11a6a9380c961b9401c9e0ced9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found many crash reports of imagepipeline in our android app,
this is caused by fresco webp native memory leak, they have fixed it in v1.9.0
fixed wrong pull request of 18848
Test Plan
Release Notes