-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose InputAccessoryView Module #18780
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Apr 10, 2018
swissmanu
force-pushed
the
expose-inputaccessoryview
branch
from
April 10, 2018 06:37
e642284
to
703bac2
Compare
swissmanu
force-pushed
the
expose-inputaccessoryview
branch
from
April 10, 2018 06:43
703bac2
to
a3ffa23
Compare
Thanks! In the meantime it should be possible to import it using haste ( |
janicduplessis
approved these changes
Apr 11, 2018
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
This pull request has been imported. This does not imply the PR has been approved.
label
Apr 11, 2018
facebook-github-bot
approved these changes
Apr 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: The latest release of react-native (0.55.2) does not expose the new `InputAccessoryView` component; It can't be accessed at all. This change fixes this problem. * Problem: Snack showing the problem: https://snack.expo.io/B1fDQRYif * Proof: `RNTester` still works with adapted imports No related PRs. [IOS] [BUGFIX] [InputAccessoryView] - Expose `InputAccessoryView` so it can be imported Closes facebook#18780 Differential Revision: D7581729 Pulled By: hramos fbshipit-source-id: d61ab1f167360e829e32b93fb5414d2f7e57e115
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: The latest release of react-native (0.55.2) does not expose the new `InputAccessoryView` component; It can't be accessed at all. This change fixes this problem. * Problem: Snack showing the problem: https://snack.expo.io/B1fDQRYif * Proof: `RNTester` still works with adapted imports No related PRs. [IOS] [BUGFIX] [InputAccessoryView] - Expose `InputAccessoryView` so it can be imported Closes facebook#18780 Differential Revision: D7581729 Pulled By: hramos fbshipit-source-id: d61ab1f167360e829e32b93fb5414d2f7e57e115
bunnyc1986
pushed a commit
to bunnyc1986/react-native
that referenced
this pull request
May 11, 2018
Summary: The latest release of react-native (0.55.2) does not expose the new `InputAccessoryView` component; It can't be accessed at all. This change fixes this problem. * Problem: Snack showing the problem: https://snack.expo.io/B1fDQRYif * Proof: `RNTester` still works with adapted imports No related PRs. [IOS] [BUGFIX] [InputAccessoryView] - Expose `InputAccessoryView` so it can be imported Closes facebook#18780 Differential Revision: D7581729 Pulled By: hramos fbshipit-source-id: d61ab1f167360e829e32b93fb5414d2f7e57e115
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: The latest release of react-native (0.55.2) does not expose the new `InputAccessoryView` component; It can't be accessed at all. This change fixes this problem. * Problem: Snack showing the problem: https://snack.expo.io/B1fDQRYif * Proof: `RNTester` still works with adapted imports No related PRs. [IOS] [BUGFIX] [InputAccessoryView] - Expose `InputAccessoryView` so it can be imported Closes facebook#18780 Differential Revision: D7581729 Pulled By: hramos fbshipit-source-id: d61ab1f167360e829e32b93fb5414d2f7e57e115
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 11, 2018
Summary: The latest release of react-native (0.55.2) does not expose the new `InputAccessoryView` component; It can't be accessed at all. This change fixes this problem. * Problem: Snack showing the problem: https://snack.expo.io/B1fDQRYif * Proof: `RNTester` still works with adapted imports No related PRs. [IOS] [BUGFIX] [InputAccessoryView] - Expose `InputAccessoryView` so it can be imported Closes facebook#18780 Differential Revision: D7581729 Pulled By: hramos fbshipit-source-id: d61ab1f167360e829e32b93fb5414d2f7e57e115
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 11, 2018
Summary: The latest release of react-native (0.55.2) does not expose the new `InputAccessoryView` component; It can't be accessed at all. This change fixes this problem. * Problem: Snack showing the problem: https://snack.expo.io/B1fDQRYif * Proof: `RNTester` still works with adapted imports No related PRs. [IOS] [BUGFIX] [InputAccessoryView] - Expose `InputAccessoryView` so it can be imported Closes facebook#18780 Differential Revision: D7581729 Pulled By: hramos fbshipit-source-id: d61ab1f167360e829e32b93fb5414d2f7e57e115
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Aug 17, 2018
Summary: The latest release of react-native (0.55.2) does not expose the new `InputAccessoryView` component; It can't be accessed at all. This change fixes this problem. * Problem: Snack showing the problem: https://snack.expo.io/B1fDQRYif * Proof: `RNTester` still works with adapted imports No related PRs. [IOS] [BUGFIX] [InputAccessoryView] - Expose `InputAccessoryView` so it can be imported Closes facebook/react-native#18780 Differential Revision: D7581729 Pulled By: hramos fbshipit-source-id: d61ab1f167360e829e32b93fb5414d2f7e57e115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Import Started
This pull request has been imported. This does not imply the PR has been approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of react-native (0.55.2) does not expose the new
InputAccessoryView
component; It can't be accessed at all. This change fixes this problem.Test Plan
RNTester
still works with adapted importsRelated PRs
No related PRs.
Release Notes
[IOS] [BUGFIX] [InputAccessoryView] - Expose
InputAccessoryView
so it can be imported