Fix Android comment and docblock typos #17049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attention: @janicduplessis Generated by 🚫 dangerJS |
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot shipit |
|
neat! |
facebook-github-bot
added
the
Import Started
shergin
changed the title
facebook-github-bot
approved these changes
Dec 4, 2017
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 4, 2017
Summary: :wave: Hello! Thanks for react-native, it’s a great project. I was digging into the Android implementation in _ReactAndroid_ and noticed a couple typos in the documentation. I went through and tried to fix all the typos I could find using [aspell](http://aspell.net). Not applicable: these changes are only to comments, and CI should be skipped. [ANDROID][ENHANCEMENT][*] - Correct comment and docblock typos Closes #17049 Differential Revision: D6472182 Pulled By: shergin fbshipit-source-id: 7e62cab118609596b483d1cf16c3abf651d6753b
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 4, 2017
Summary: :wave: Hello! Thanks for react-native, it’s a great project. I was digging into the Android implementation in _ReactAndroid_ and noticed a couple typos in the documentation. I went through and tried to fix all the typos I could find using [aspell](http://aspell.net). Not applicable: these changes are only to comments, and CI should be skipped. [ANDROID][ENHANCEMENT][*] - Correct comment and docblock typos Closes facebook/react-native#17049 Differential Revision: D6472182 Pulled By: shergin fbshipit-source-id: 7e62cab118609596b483d1cf16c3abf651d6753b
facebook-github-bot
pushed a commit
to facebookarchive/profilo
that referenced
this pull request
Dec 4, 2017
Summary: :wave: Hello! Thanks for react-native, it’s a great project. I was digging into the Android implementation in _ReactAndroid_ and noticed a couple typos in the documentation. I went through and tried to fix all the typos I could find using [aspell](http://aspell.net). Not applicable: these changes are only to comments, and CI should be skipped. [ANDROID][ENHANCEMENT][*] - Correct comment and docblock typos Closes facebook/react-native#17049 Differential Revision: D6472182 Pulled By: shergin fbshipit-source-id: 7e62cab118609596b483d1cf16c3abf651d6753b
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: :wave: Hello! Thanks for react-native, it’s a great project. I was digging into the Android implementation in _ReactAndroid_ and noticed a couple typos in the documentation. I went through and tried to fix all the typos I could find using [aspell](http://aspell.net). Not applicable: these changes are only to comments, and CI should be skipped. [ANDROID][ENHANCEMENT][*] - Correct comment and docblock typos Closes facebook#17049 Differential Revision: D6472182 Pulled By: shergin fbshipit-source-id: 7e62cab118609596b483d1cf16c3abf651d6753b
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: :wave: Hello! Thanks for react-native, it’s a great project. I was digging into the Android implementation in _ReactAndroid_ and noticed a couple typos in the documentation. I went through and tried to fix all the typos I could find using [aspell](http://aspell.net). Not applicable: these changes are only to comments, and CI should be skipped. [ANDROID][ENHANCEMENT][*] - Correct comment and docblock typos Closes facebook#17049 Differential Revision: D6472182 Pulled By: shergin fbshipit-source-id: 7e62cab118609596b483d1cf16c3abf651d6753b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
👋 Hello! Thanks for react-native, it’s a great project.
I was digging into the Android implementation in ReactAndroid and noticed a couple typos in the documentation. I went through and tried to fix all the typos I could find using aspell.
Test Plan
Not applicable: these changes are only to comments, and CI should be skipped.
Release Notes
[ANDROID][ENHANCEMENT][*] - Correct comment and docblock typos