Export YellowBox API #16709
Closed
Export YellowBox API #16709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow end users to access the YellowBox API so that warnings can be properly ignored via the API first introduced in a974c14
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 7, 2017
There was a problem hiding this comment.
@ide is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cdlewis
pushed a commit
to cdlewis/react-native
that referenced
this pull request
Nov 19, 2017
Summary: Allow end users to access the YellowBox API so that warnings can be properly ignored via the API first introduced in a974c14. Based on that API, you should be able to do the following: ``` import { YellowBox } from 'react-native'; YellowBox.ignoreWarnings(['Warning: ...']); ``` However, if you actually try this today, it results in a broken import error. Verified using an expo instance. First tried without the YellowBox import, observed a failure to import. Then I added the import statement, and observed no warning on my device. ``` import React from 'react'; import { StyleSheet, Text, View, YellowBox } from 'react-native'; YellowBox.ignoreWarnings(['hey']); export default class App extends React.Component { render() { console.warn('hey!'); return ( <View style={styles.container}> <Text>Open up App.js to start working on your app!</Text> <Text>Changes you make will automatically reload.</Text> <Text>Shake your phone to open the developer menu.</Text> </View> ); } } const styles = StyleSheet.create({ container: { flex: 1, backgroundColor: '#fff', alignItems: 'center', justifyContent: 'center', }, }); ``` [GENERAL] [ENHANCEMENT] [YellowBox] - Export YellowBox API so warnings can be ignored using a non-deprecated API. Closes facebook#16709 Differential Revision: D6254819 Pulled By: hramos fbshipit-source-id: ff92f32e4dedfb01f6902f54fabc62eb64468554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow end users to access the YellowBox API so that warnings can be properly ignored via the API first introduced in a974c14. Based on that API, you should be able to do the following:
However, if you actually try this today, it results in a broken import error.
Test Plan
Verified using an expo instance. First tried without the YellowBox import, observed a failure to import. Then I added the import statement, and observed no warning on my device.
Release Notes
[GENERAL] [ENHANCEMENT] [YellowBox] - Export YellowBox API so warnings can be ignored using a non-deprecated API.