[podspec] Define pod_target_xcconfig for PrivateDatabase
#16665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't strictly need this since all the other subspecs that use this set up the header search path for ReactCommon anyway but do it just for correctness.
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information @facebook-github-bot label Core Team Generated by 🚫 dangerJS |
|
👍 @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 4, 2017
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cdlewis
pushed a commit
to cdlewis/react-native
that referenced
this pull request
Nov 19, 2017
Summary: We don't strictly need this since all the other subspecs that use this set up the header search path for ReactCommon anyway but do it just for correctness. Closes facebook#16665 Differential Revision: D6241796 Pulled By: hramos fbshipit-source-id: 19e6363e570d38f06ea970395d68b9cea7fd02ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't strictly need this since all the other subspecs that use this set up the header search path for ReactCommon anyway but do it just for correctness.
Test Plan: install iOS pods
Release Notes
[podspec] Define
pod_target_xcconfigfor PrivateDatabase