[0.62.0-rc.3] Catalyst macOS build issue typedef redefinition with different types #27845
Labels
Comments
This comment has been minimized.
This comment has been minimized.
6 tasks
mgcrea
changed the title
mgcrea
changed the title
|
FYI this bug still exists in the latest 0.62.0-rc.3 release. |
|
Hi @mgcrea, Have you had any success since posting this? I'm having the same problem and got stuck at libcrypto.a error. |
|
@0xmtn @mgcrea I fixed this with updating my iOS Deployment Target Build setting in my app to be 9.0 and my Change this: ios/Podfile to this: ios/Podfile Don't forget to I guess this means flipper-folly doesn't like iOS version 10 as a deployment target... |
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 27, 2020
…liasing (#29609) Summary: I noticed when porting my iOS app to macOS via Catalyst that the text rendering was somewhat different on the two platforms. Text looked blurry and over-weight on macOS, even when disabling the Catalyst scaling transform. I hazily remembered that I'd seen this problem before in my old Cocoa development days: this kind of blurring occurs when rendering text with sub-pixel anti-aliasing into an offscreen buffer which will then be traditionally composited, because when the SPAA algorithm attempts to blend with the underlying content (i.e. in the offscreen buffer), there isn't any. SPAA is disabled on iOS, so the issue wouldn't appear there. On macOS, typical approachs to displaying text (e.g. `CATextLayer`) normally disable SPAA, since it's been incompatible with the platform's compositing strategy since the transition to layer-backed views some years ago. But React Native uses `NSLayoutManager` to rasterize text (rather than relying on the system render server via `CATextLayer`), and that class doesn't touch the context's font smoothing bit before drawing. This change makes macOS/Catalyst text rendering consistent with iOS text rendering by disabling SPAA. It appears that the code I've modified is in the process of being refactored (for Fabric?). It looks like [this](https://github.com/facebook/react-native/blob/8d6b41e9bcede07fb627d57cf6c11050ae590d57/ReactCommon/react/renderer/textlayoutmanager/platform/ios/RCTTextLayoutManager.mm#L111) is the corresponding place in the new code (sammy-SC, is that right?). I'm happy to include a change to the new renderer in this patch if someone can point me at how to test that change. ## Changelog [iOS] [Fixed] - Improved text rendering on macOS Catalyst Pull Request resolved: #29609 Test Plan: 1. Prepare RNTester for running on macOS (or apply [this patch](https://gist.github.com/andymatuschak/d0f5b4fc1a28efc4f860801aa1deddcd) to handle parts 1 and 2, but you'll still need to do part 3): 1. Open the workspace, navigate to the `RNTester` target's configuration, and check the "Mac" checkbox under "Deployment Info. 2. Flipper doesn't yet compile for Catalyst (#27845), so you must disable it by: a) commenting out `use_flipper!` and `flipper_post_install` in the Podfile, then running `pod install`; and b) removing the `FB_SONARKIT_ENABLED` preprocessor flags in the Xcode project. 3. macOS has different signing rules from iOS; you must set a development team in the "Signing & Capabilities" tab of the `RNTester` target configuration pane. Unfortunately, you must also do this in the `Pods` project for the `React-Core-AccessibilityResources` target ([this is an issue which CocoaPods must fix](CocoaPods/CocoaPods#8891)). 2. Run RNTester with and without the patch. You'll see that the font hinting is overweight without the patch; see screenshots below (incorrect rendering above, correct rendering below; note that fonts still remain slightly blurred because of Catalyst's window scaling transform, but that's removed on Big Sur).   Reviewed By: PeteTheHeat Differential Revision: D23344751 Pulled By: sammy-SC fbshipit-source-id: 1bbf682b681e381a8a90e152245d9b0df8ec7697
This was referenced Sep 30, 2020
philippeauriach
pushed a commit
to philippeauriach/react-native
that referenced
this issue
May 5, 2021
…liasing (facebook#29609) Summary: I noticed when porting my iOS app to macOS via Catalyst that the text rendering was somewhat different on the two platforms. Text looked blurry and over-weight on macOS, even when disabling the Catalyst scaling transform. I hazily remembered that I'd seen this problem before in my old Cocoa development days: this kind of blurring occurs when rendering text with sub-pixel anti-aliasing into an offscreen buffer which will then be traditionally composited, because when the SPAA algorithm attempts to blend with the underlying content (i.e. in the offscreen buffer), there isn't any. SPAA is disabled on iOS, so the issue wouldn't appear there. On macOS, typical approachs to displaying text (e.g. `CATextLayer`) normally disable SPAA, since it's been incompatible with the platform's compositing strategy since the transition to layer-backed views some years ago. But React Native uses `NSLayoutManager` to rasterize text (rather than relying on the system render server via `CATextLayer`), and that class doesn't touch the context's font smoothing bit before drawing. This change makes macOS/Catalyst text rendering consistent with iOS text rendering by disabling SPAA. It appears that the code I've modified is in the process of being refactored (for Fabric?). It looks like [this](https://github.com/facebook/react-native/blob/8d6b41e9bcede07fb627d57cf6c11050ae590d57/ReactCommon/react/renderer/textlayoutmanager/platform/ios/RCTTextLayoutManager.mm#L111) is the corresponding place in the new code (sammy-SC, is that right?). I'm happy to include a change to the new renderer in this patch if someone can point me at how to test that change. ## Changelog [iOS] [Fixed] - Improved text rendering on macOS Catalyst Pull Request resolved: facebook#29609 Test Plan: 1. Prepare RNTester for running on macOS (or apply [this patch](https://gist.github.com/andymatuschak/d0f5b4fc1a28efc4f860801aa1deddcd) to handle parts 1 and 2, but you'll still need to do part 3): 1. Open the workspace, navigate to the `RNTester` target's configuration, and check the "Mac" checkbox under "Deployment Info. 2. Flipper doesn't yet compile for Catalyst (facebook#27845), so you must disable it by: a) commenting out `use_flipper!` and `flipper_post_install` in the Podfile, then running `pod install`; and b) removing the `FB_SONARKIT_ENABLED` preprocessor flags in the Xcode project. 3. macOS has different signing rules from iOS; you must set a development team in the "Signing & Capabilities" tab of the `RNTester` target configuration pane. Unfortunately, you must also do this in the `Pods` project for the `React-Core-AccessibilityResources` target ([this is an issue which CocoaPods must fix](CocoaPods/CocoaPods#8891)). 2. Run RNTester with and without the patch. You'll see that the font hinting is overweight without the patch; see screenshots below (incorrect rendering above, correct rendering below; note that fonts still remain slightly blurred because of Catalyst's window scaling transform, but that's removed on Big Sur).   Reviewed By: PeteTheHeat Differential Revision: D23344751 Pulled By: sammy-SC fbshipit-source-id: 1bbf682b681e381a8a90e152245d9b0df8ec7697
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
React Native version:
Steps To Reproduce
npx react-native init SandboxProject_62 --version 0.62.0-rc.1Describe what you expected to happen:
Successful build for macOS target
Errors
If I comment out this line, Flipper-Folly build does seem to pass but I end up with an OpenSSL linking error:
Would be really awesome to have a working macOS target for the 0.62 release as everything seems to be pretty ready.
The text was updated successfully, but these errors were encountered: