Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] add test case for template #23432

Closed
gengjiawen opened this issue Feb 13, 2019 · 6 comments
Closed

[META] add test case for template #23432

gengjiawen opened this issue Feb 13, 2019 · 6 comments
Labels
Contributor A React Native contributor. Partner Resolution: Locked This issue was locked by the bot. 🔩Test Infrastructure Test infrastructure and continuous integration.

Comments

@gengjiawen
Copy link
Contributor

gengjiawen commented Feb 13, 2019

Test template is working in ci system. With this the when release new version should be more confident.

I may not have time for this recently, any pr is welcome.

@gengjiawen gengjiawen added the Type: Discussion Long running discussion. label Feb 13, 2019
@facebook-github-bot facebook-github-bot added Contributor A React Native contributor. Partner labels Feb 13, 2019
@gengjiawen gengjiawen added 🔩Test Infrastructure Test infrastructure and continuous integration. and removed Type: Discussion Long running discussion. labels Feb 13, 2019
@gengjiawen
Copy link
Contributor Author

Related issue: #23893.

@gengjiawen
Copy link
Contributor Author

@grabbou Is there a mechanism we can init a project from a local template. With this feature, we can test CI in current workflow to prevent bug and regressions.

cc @dulmandakh @hramos @cpojer

@grabbou
Copy link
Contributor

grabbou commented Mar 15, 2019 via email

@gengjiawen
Copy link
Contributor Author

gengjiawen commented Mar 15, 2019

I see, thanks.
But it maybe a litter cumbersome since it requires run npm pack first.

Maybe still can work with it in ci. I will see what I can do.

@grabbou
Copy link
Contributor

grabbou commented Mar 15, 2019 via email

@cpojer
Copy link
Contributor

cpojer commented May 9, 2019

We have this now.

@cpojer cpojer closed this as completed May 9, 2019
@facebook facebook locked as resolved and limited conversation to collaborators May 9, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contributor A React Native contributor. Partner Resolution: Locked This issue was locked by the bot. 🔩Test Infrastructure Test infrastructure and continuous integration.
Projects
None yet
Development

No branches or pull requests

5 participants