Skip to content

Commit

Permalink
Revert D7473762: [react-native][PR] added in snapAlignment for horizo…
Browse files Browse the repository at this point in the history
…ntal android scrollView

Differential Revision:
D7473762

Original commit changeset: ad4778b83f9f

fbshipit-source-id: 90f002ad60d26abd801a7a9d37e71254b063faef
  • Loading branch information
mdvacca authored and facebook-github-bot committed Apr 11, 2018
1 parent c9a6b85 commit fcecc15
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public class ReactHorizontalScrollView extends HorizontalScrollView implements
private @Nullable Drawable mEndBackground;
private int mEndFillColor = Color.TRANSPARENT;
private int mSnapInterval = 0;
private String mSnapAlignment = "start";
private ReactViewBackgroundManager mReactBackgroundManager;

public ReactHorizontalScrollView(Context context) {
Expand Down Expand Up @@ -97,13 +96,6 @@ public void setPagingEnabled(boolean pagingEnabled) {

public void setSnapInterval(int snapInterval) {
mSnapInterval = snapInterval;
if(snapInterval != 0) {
mPagingEnabled = true;
}
}

public void setSnapAlignment(String snapAlignment) {
mSnapAlignment = snapAlignment;
}

public void flashScrollIndicators() {
Expand Down Expand Up @@ -244,17 +236,6 @@ private int getSnapInterval() {
return getWidth();
}

private int getAlignmentOffset() {
int width = getWidth();
int snapInterval = getSnapInterval();
if (mSnapAlignment.equals("center")) {
return (width - snapInterval)/2;
} else if(mSnapAlignment.equals("end")) {
return (width - snapInterval);
}
return 0;
}

public void setEndFillColor(int color) {
if (color != mEndFillColor) {
mEndFillColor = color;
Expand Down Expand Up @@ -368,7 +349,7 @@ private void smoothScrollToPage(int velocity) {
if (predictedX > page * width + width / 2) {
page = page + 1;
}
smoothScrollTo(page * width - getAlignmentOffset(), getScrollY());
smoothScrollTo(page * width, getScrollY());
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,6 @@ public void setSnapToInterval(ReactHorizontalScrollView view, float snapToInterv
view.setSnapInterval((int) (snapToInterval * screenDisplayMetrics.density));
}

@ReactProp(name = "snapToAlignment")
public void setSnapToAlignment(ReactHorizontalScrollView view, String snapToAlignment) {
view.setSnapAlignment(snapToAlignment);
}

@ReactProp(name = ReactClippingViewGroupHelper.PROP_REMOVE_CLIPPED_SUBVIEWS)
public void setRemoveClippedSubviews(ReactHorizontalScrollView view, boolean removeClippedSubviews) {
view.setRemoveClippedSubviews(removeClippedSubviews);
Expand Down

0 comments on commit fcecc15

Please sign in to comment.