delete typealias RunLoopObserver::Unique

Differential Revision: D64302758
facebook · Oct 16, 2024 · fa50e13 · fa50e13
1 parent 7b62e47
commit fa50e13
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/packages/react-native/React/Fabric/AppleEventBeat.cpp b/packages/react-native/React/Fabric/AppleEventBeat.cpp
@@ -13,7 +13,7 @@ namespace facebook::react {
 
 AppleEventBeat::AppleEventBeat(
     std::shared_ptr<OwnerBox> ownerBox,
-    RunLoopObserver::Unique uiRunLoopObserver,
+    std::unique_ptr<const RunLoopObserver> uiRunLoopObserver,
     RuntimeExecutor runtimeExecutor)
     : EventBeat(std::move(ownerBox), std::move(runtimeExecutor)),
       uiRunLoopObserver_(std::move(uiRunLoopObserver)) {

diff --git a/packages/react-native/React/Fabric/AppleEventBeat.h b/packages/react-native/React/Fabric/AppleEventBeat.h
@@ -22,7 +22,7 @@ class AppleEventBeat : public EventBeat, public RunLoopObserver::Delegate {
  public:
   AppleEventBeat(
       std::shared_ptr<OwnerBox> ownerBox,
-      RunLoopObserver::Unique uiRunLoopObserver,
+      std::unique_ptr<const RunLoopObserver> uiRunLoopObserver,
       RuntimeExecutor runtimeExecutor);
 
 #pragma mark - RunLoopObserver::Delegate
@@ -32,7 +32,7 @@ class AppleEventBeat : public EventBeat, public RunLoopObserver::Delegate {
       RunLoopObserver::Activity activity) const noexcept override;
 
  private:
-  RunLoopObserver::Unique uiRunLoopObserver_;
+  std::unique_ptr<const RunLoopObserver> uiRunLoopObserver_;
 };
 
 } // namespace facebook::react
diff --git a/packages/react-native/React/Fabric/RCTScheduler.mm b/packages/react-native/React/Fabric/RCTScheduler.mm
@@ -108,7 +108,7 @@ @implementation RCTScheduler {
   std::shared_ptr<LayoutAnimationDriver> _animationDriver;
   std::shared_ptr<SchedulerDelegateProxy> _delegateProxy;
   std::shared_ptr<LayoutAnimationDelegateProxy> _layoutAnimationDelegateProxy;
-  RunLoopObserver::Unique _uiRunLoopObserver;
+  std::unique_ptr<const PlatformRunLoopObserver> _uiRunLoopObserver;
 }
 
 - (instancetype)initWithToolbox:(SchedulerToolbox)toolbox

diff --git a/packages/react-native/ReactCommon/react/utils/RunLoopObserver.h b/packages/react-native/ReactCommon/react/utils/RunLoopObserver.h
@@ -18,8 +18,6 @@ namespace facebook::react {
  */
 class RunLoopObserver {
  public:
-  using Unique = std::unique_ptr<const RunLoopObserver>;
-
   /*
    * The concept of an owner.
    * A run loop observer normally observes a run loop running on a different