Skip to content

Commit

Permalink
Fixing the packager infinite loop on Windows
Browse files Browse the repository at this point in the history 
Summary: The issue here #2787

The root path '/' dosn't match windows root path
Closes #2789

Reviewed By: @​svcscm

Differential Revision: D2452718

Pulled By: @martinbigio
  • Loading branch information
@mqli
mqli authored and facebook-github-bot-4 committed Sep 18, 2015
1 parent 4fd03ba commit f5409c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packager/react-packager/src/DependencyResolver/DependencyGraph/ResolutionRequest.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ class ResolutionRequest {
realModuleName => {
const searchQueue = [];
for (let currDir = path.dirname(fromModule.path);
currDir !== '/';
currDir !== path.parse(fromModule.path).root;
currDir = path.dirname(currDir)) {
searchQueue.push(
path.join(currDir, 'node_modules', realModuleName)
Expand Down

2 comments on commit f5409c1

@hejun-lyne
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find 'parse' method in osx!

TypeError: Object [object Object] has no method 'parse'
at .../react-native/packager/react-packager/src/DependencyResolver/DependencyGraph/ResolutionRequest.js:229:33

@ide
Copy link
Contributor

@ide ide commented on f5409c1 Sep 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hejun-lyne what version of Node are you using?

Please sign in to comment.