Skip to content

Commit

Permalink
Fix crash when tapping full screen button on video ad
Browse files Browse the repository at this point in the history
Summary:
Fragment was assigned incorrect `tag` and `surfaceID` (`surfaceID` is the important one).

Wrong `surfaceID` means that `navigationCoordinator` is never resolved. As a result of navigationCoordinator not being assigned, tapping a video ad on Marketplace results in showing video ad overlay rather than showing full screen video.

Reviewed By: JoshuaGross

Differential Revision: D16646492

fbshipit-source-id: 0da5c56ecb7c81e9f4a9469a3626ccd430a01558
  • Loading branch information
sammy-SC authored and facebook-github-bot committed Aug 5, 2019
1 parent 28d5018 commit e557901
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ReactCommon/fabric/uimanager/UIManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ SharedShadowNode UIManager::createNode(
componentDescriptor.createEventEmitter(std::move(eventTarget), tag);
auto const props = componentDescriptor.cloneProps(nullptr, rawProps);
auto const state = componentDescriptor.createInitialState(
ShadowNodeFragment{surfaceId, tag, props, eventEmitter});
ShadowNodeFragment{tag, surfaceId, props, eventEmitter});

auto shadowNode = componentDescriptor.createShadowNode({
/* .tag = */ tag,
Expand Down

0 comments on commit e557901

Please sign in to comment.