Skip to content

Commit

Permalink
Remove hermesc build dir for non-Hermes build
Browse files Browse the repository at this point in the history
Summary: Changelog: [iOS][Fixed] - Remove hermesc build dir for non-Hermes build.

Reviewed By: christophpurrer

Differential Revision: D41052884

fbshipit-source-id: c9e85ca06cef79fa35e81972181558d44ca93d90
  • Loading branch information
dmytrorykun authored and facebook-github-bot committed Nov 7, 2022
1 parent 7f60bcc commit c05e6c4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions scripts/cocoapods/jsengine.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,7 @@ def remove_copy_hermes_framework_script_phase(installer, react_native_path)
end
project.save()
end

def remove_hermesc_build_dir(react_native_path)
%x(rm -rf #{react_native_path}/sdks/hermes-engine/build_host_hermesc)
end
1 change: 1 addition & 0 deletions scripts/react_native_pods.rb
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ def react_native_post_install(installer, react_native_path = "../node_modules/re
add_copy_hermes_framework_script_phase(installer, react_native_path)
else
remove_copy_hermes_framework_script_phase(installer, react_native_path)
remove_hermesc_build_dir(react_native_path)
end

ReactNativePodsUtils.exclude_i386_architecture_while_using_hermes(installer)
Expand Down

0 comments on commit c05e6c4

Please sign in to comment.