Annotate empty objects in xplat

Reviewed By: pieterv Differential Revision: D40134090 fbshipit-source-id: 3dd0bdb41ed559d9f72f0ff35c14e5551789fcc0
facebook · Oct 6, 2022 · abb21dd · abb21dd
1 parent 7c36d0b
commit abb21dd
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 16 deletions.
diff --git a/Libraries/Animated/AnimatedImplementation.js b/Libraries/Animated/AnimatedImplementation.js
@@ -367,7 +367,7 @@ const parallel = function (
 ): CompositeAnimation {
   let doneCount = 0;
   // Make sure we only call stop() at most once for each animation
-  const hasEnded = {};
+  const hasEnded: {[number]: boolean} = {};
   const stopTogether = !(config && config.stopTogether === false);
 
   const result = {

diff --git a/Libraries/Animated/NativeAnimatedHelper.js b/Libraries/Animated/NativeAnimatedHelper.js
@@ -49,8 +49,12 @@ const useSingleOpBatching =
   ReactNativeFeatureFlags.animatedShouldUseSingleOp();
 let flushQueueTimeout = null;
 
-const eventListenerGetValueCallbacks = {};
-const eventListenerAnimationFinishedCallbacks = {};
+const eventListenerGetValueCallbacks: {
+  [$FlowFixMe | number]: ((value: number) => void) | void,
+} = {};
+const eventListenerAnimationFinishedCallbacks: {
+  [$FlowFixMe | number]: EndCallback | void,
+} = {};
 let globalEventEmitterGetValueListener: ?EventSubscription = null;
 let globalEventEmitterAnimationFinishedListener: ?EventSubscription = null;
 
@@ -79,7 +83,7 @@ const nativeOps: ?typeof NativeAnimatedModule = useSingleOpBatching
         'addListener', // 20
         'removeListener', // 21
       ];
-      return apis.reduce((acc, functionName, i) => {
+      return apis.reduce<{[string]: number}>((acc, functionName, i) => {
         // These indices need to be kept in sync with the indices in native (see NativeAnimatedModule in Java, or the equivalent for any other native platform).
         // $FlowFixMe[prop-missing]
         acc[functionName] = i + 1;

diff --git a/Libraries/Inspector/NetworkOverlay.js b/Libraries/Inspector/NetworkOverlay.js
@@ -151,7 +151,7 @@ class NetworkOverlay extends React.Component<Props, State> {
       this.setState(({requests}) => {
         const networkRequestInfo = requests[xhrIndex];
         if (!networkRequestInfo.requestHeaders) {
-          networkRequestInfo.requestHeaders = {};
+          networkRequestInfo.requestHeaders = ({}: {[any]: any});
         }
         networkRequestInfo.requestHeaders[header] = value;
         return {requests};

diff --git a/...ples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js b/...ples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesHoverablePointers.js
@@ -36,8 +36,8 @@ function PointerEventAttributesHoverablePointersTestCase(
 ) {
   const {harness} = props;
 
-  const detected_pointertypesRef = useRef({});
-  const detected_eventTypesRef = useRef({});
+  const detected_pointertypesRef = useRef(({}: {[string]: boolean}));
+  const detected_eventTypesRef = useRef(({}: {[string]: boolean}));
   const expectedPointerIdRef = useRef(NaN);
 
   const [square1Visible, setSquare1Visible] = useState(true);
@@ -189,7 +189,7 @@ function PointerEventAttributesHoverablePointersTestCase(
           eventList.length
         ) {
           setSquare1Visible(false);
-          detected_eventTypesRef.current = {};
+          detected_eventTypesRef.current = ({}: {[string]: boolean});
           setSquare2Visible(true);
           expectedPointerIdRef.current = NaN;
         }

diff --git a/...amples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js b/...amples/Experimental/W3CPointerEventPlatformTests/PointerEventAttributesNoHoverPointers.js
@@ -35,8 +35,8 @@ function PointerEventAttributesNoHoverPointersTestCase(
 ) {
   const {harness} = props;
 
-  const detected_pointertypesRef = useRef({});
-  const detected_eventTypesRef = useRef({});
+  const detected_pointertypesRef = useRef(({}: {[string]: boolean}));
+  const detected_eventTypesRef = useRef(({}: {[string]: boolean}));
   const expectedPointerIdRef = useRef(NaN);
 
   const [square1Visible, setSquare1Visible] = useState(true);
@@ -157,7 +157,7 @@ function PointerEventAttributesNoHoverPointersTestCase(
           eventList.length
         ) {
           setSquare1Visible(false);
-          detected_eventTypesRef.current = {};
+          detected_eventTypesRef.current = ({}: {[string]: boolean});
           setSquare2Visible(true);
           expectedPointerIdRef.current = NaN;
         }

diff --git a/...n-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPointerMove.js b/...n-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPointerMove.js
@@ -24,7 +24,7 @@ function PointerEventPointerMoveTestCase(
 ) {
   const {harness} = props;
 
-  const detectedPointerTypesRef = useRef({});
+  const detectedPointerTypesRef = useRef(({}: {[string]: boolean}));
   const testPointerMove = harness.useAsyncTest('pointermove event received');
 
   const handlers = useTestEventHandler(

diff --git a/.../js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js b/.../js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js
@@ -45,7 +45,7 @@ function PointerEventPrimaryTouchPointerTestCase(
 ) {
   const {harness} = props;
 
-  const detected_eventsRef = useRef({});
+  const detected_eventsRef = useRef(({}: {[string]: boolean}));
 
   const handleIncomingPointerEvent = useCallback(
     (boxLabel: string, eventType: string, isPrimary: boolean) => {

diff --git a/...es/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventSupport.js b/...es/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventSupport.js
@@ -216,7 +216,7 @@ export function useTestEventHandler(
   const eventProps: any = useMemo(() => {
     const handlerFactory = (eventName: string) => (event: any) =>
       handler(event, eventName);
-    const props = {};
+    const props: {[string]: (event: any) => void} = {};
     for (const eventName of eventNames) {
       const eventPropName =
         'on' + eventName[0].toUpperCase() + eventName.slice(1);

diff --git a/packages/rn-tester/js/utils/RNTesterReducer.js b/packages/rn-tester/js/utils/RNTesterReducer.js
@@ -24,7 +24,7 @@ const getUpdatedBookmarks = ({
   key,
   bookmarks,
 }: {
-  exampleType: string,
+  exampleType: 'apis' | 'components',
   key: string,
   bookmarks: ComponentList,
 }) => {
@@ -47,7 +47,7 @@ const getUpdatedRecentlyUsed = ({
   key,
   recentlyUsed,
 }: {
-  exampleType: string,
+  exampleType: 'apis' | 'components',
   key: string,
   recentlyUsed: ComponentList,
 }) => {