Skip to content

Commit

Permalink
Pass testID down in Modal
Browse files Browse the repository at this point in the history
Summary:
Changelog:
[General][Fixed] - Modal accepts a testID but didn't forward it to RCTModalHostView, therefore not making it show up for e2e tests depending on viewhierarchy.

Reviewed By: motiz88

Differential Revision: D32354377

fbshipit-source-id: 51df3a1f81c4b77240e83101b367b033ce98b0c7
  • Loading branch information
GijsWeterings authored and facebook-github-bot committed Nov 11, 2021
1 parent 9d71b16 commit 5050e7e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Libraries/Modal/Modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,8 @@ class Modal extends React.Component<Props> {
// $FlowFixMe[method-unbinding] added when improving typing for this parameters
onStartShouldSetResponder={this._shouldSetResponder}
supportedOrientations={this.props.supportedOrientations}
onOrientationChange={this.props.onOrientationChange}>
onOrientationChange={this.props.onOrientationChange}
testID={this.props.testID}>
<VirtualizedListContextResetter>
<ScrollView.Context.Provider value={null}>
<View
Expand Down

0 comments on commit 5050e7e

Please sign in to comment.