Unbreak the build

Summary: build-break overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: fbandroid_sheriff Differential Revision: D23325277 fbshipit-source-id: 20e4fb649ce8a0c8640a5ff1c5eb0ff310a4cc22
facebook · Aug 25, 2020 · 287cf07 · 287cf07
1 parent 8ce57ec
commit 287cf07
Show file tree

Hide file tree

Showing 16 changed files with 73 additions and 73 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAccessibilityManagerSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAccessibilityManagerSpec.java
@@ -32,13 +32,13 @@ public NativeAccessibilityManagerSpec(ReactApplicationContext reactContext) {
   public abstract void getCurrentReduceTransparencyState(Callback onSuccess, Callback onError);
 
   @ReactMethod
-  public abstract void getCurrentInvertColorsState(Callback onSuccess, Callback onError);
+  public abstract void getCurrentBoldTextState(Callback onSuccess, Callback onError);
 
   @ReactMethod
   public abstract void getCurrentGrayscaleState(Callback onSuccess, Callback onError);
 
   @ReactMethod
-  public abstract void getCurrentBoldTextState(Callback onSuccess, Callback onError);
+  public abstract void getCurrentInvertColorsState(Callback onSuccess, Callback onError);
 
   @ReactMethod
   public abstract void setAccessibilityFocus(double reactTag);

diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedModuleSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedModuleSpec.java
@@ -26,33 +26,33 @@ public NativeAnimatedModuleSpec(ReactApplicationContext reactContext) {
   }
 
   @ReactMethod
-  public abstract void dropAnimatedNode(double tag);
+  public abstract void connectAnimatedNodes(double parentTag, double childTag);
 
   @ReactMethod
-  public abstract void connectAnimatedNodes(double parentTag, double childTag);
+  public abstract void dropAnimatedNode(double tag);
 
   @ReactMethod
   public abstract void stopAnimation(double animationId);
 
+  @ReactMethod
+  public abstract void disconnectAnimatedNodeFromView(double nodeTag, double viewTag);
+
   @ReactMethod
   public abstract void removeListeners(double count);
 
   @ReactMethod
-  public abstract void disconnectAnimatedNodeFromView(double nodeTag, double viewTag);
+  public abstract void flattenAnimatedNodeOffset(double nodeTag);
 
   @ReactMethod
   public abstract void removeAnimatedEventFromView(double viewTag, String eventName,
       double animatedNodeTag);
 
   @ReactMethod
-  public abstract void flattenAnimatedNodeOffset(double nodeTag);
+  public abstract void disconnectAnimatedNodes(double parentTag, double childTag);
 
   @ReactMethod
   public abstract void extractAnimatedNodeOffset(double nodeTag);
 
-  @ReactMethod
-  public abstract void disconnectAnimatedNodes(double parentTag, double childTag);
-
   @ReactMethod
   public abstract void setAnimatedNodeValue(double nodeTag, double value);
 
@@ -62,13 +62,13 @@ public abstract void removeAnimatedEventFromView(double viewTag, String eventNam
   @ReactMethod
   public abstract void setAnimatedNodeOffset(double nodeTag, double offset);
 
-  @ReactMethod
-  public abstract void restoreDefaultValues(double nodeTag);
-
   @ReactMethod
   public abstract void startAnimatingNode(double animationId, double nodeTag, ReadableMap config,
       Callback endCallback);
 
+  @ReactMethod
+  public abstract void restoreDefaultValues(double nodeTag);
+
   @ReactMethod
   public abstract void getValue(double tag, Callback saveValueCallback);
 

diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedTurboModuleSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedTurboModuleSpec.java
@@ -26,33 +26,33 @@ public NativeAnimatedTurboModuleSpec(ReactApplicationContext reactContext) {
   }
 
   @ReactMethod
-  public abstract void dropAnimatedNode(double tag);
+  public abstract void connectAnimatedNodes(double parentTag, double childTag);
 
   @ReactMethod
-  public abstract void connectAnimatedNodes(double parentTag, double childTag);
+  public abstract void dropAnimatedNode(double tag);
 
   @ReactMethod
   public abstract void stopAnimation(double animationId);
 
+  @ReactMethod
+  public abstract void disconnectAnimatedNodeFromView(double nodeTag, double viewTag);
+
   @ReactMethod
   public abstract void removeListeners(double count);
 
   @ReactMethod
-  public abstract void disconnectAnimatedNodeFromView(double nodeTag, double viewTag);
+  public abstract void flattenAnimatedNodeOffset(double nodeTag);
 
   @ReactMethod
   public abstract void removeAnimatedEventFromView(double viewTag, String eventName,
       double animatedNodeTag);
 
   @ReactMethod
-  public abstract void flattenAnimatedNodeOffset(double nodeTag);
+  public abstract void disconnectAnimatedNodes(double parentTag, double childTag);
 
   @ReactMethod
   public abstract void extractAnimatedNodeOffset(double nodeTag);
 
-  @ReactMethod
-  public abstract void disconnectAnimatedNodes(double parentTag, double childTag);
-
   @ReactMethod
   public abstract void setAnimatedNodeValue(double nodeTag, double value);
 
@@ -62,13 +62,13 @@ public abstract void removeAnimatedEventFromView(double viewTag, String eventNam
   @ReactMethod
   public abstract void setAnimatedNodeOffset(double nodeTag, double offset);
 
-  @ReactMethod
-  public abstract void restoreDefaultValues(double nodeTag);
-
   @ReactMethod
   public abstract void startAnimatingNode(double animationId, double nodeTag, ReadableMap config,
       Callback endCallback);
 
+  @ReactMethod
+  public abstract void restoreDefaultValues(double nodeTag);
+
   @ReactMethod
   public abstract void getValue(double tag, Callback saveValueCallback);
 

diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAppearanceSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAppearanceSpec.java
@@ -27,11 +27,11 @@ public NativeAppearanceSpec(ReactApplicationContext reactContext) {
   @ReactMethod
   public abstract void removeListeners(double count);
 
-  @ReactMethod
-  public abstract void addListener(String eventName);
-
   @ReactMethod(
       isBlockingSynchronousMethod = true
   )
   public abstract @Nullable String getColorScheme();
+
+  @ReactMethod
+  public abstract void addListener(String eventName);
 }
diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAsyncStorageSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAsyncStorageSpec.java
@@ -28,18 +28,18 @@ public NativeAsyncStorageSpec(ReactApplicationContext reactContext) {
   @ReactMethod
   public abstract void multiSet(ReadableArray kvPairs, Callback callback);
 
-  @ReactMethod
-  public abstract void getAllKeys(Callback callback);
-
   @ReactMethod
   public abstract void multiGet(ReadableArray keys, Callback callback);
 
   @ReactMethod
-  public abstract void clear(Callback callback);
+  public abstract void getAllKeys(Callback callback);
 
   @ReactMethod
   public abstract void multiMerge(ReadableArray kvPairs, Callback callback);
 
+  @ReactMethod
+  public abstract void clear(Callback callback);
+
   @ReactMethod
   public abstract void multiRemove(ReadableArray keys, Callback callback);
 }
diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeBlobModuleSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeBlobModuleSpec.java
@@ -38,10 +38,10 @@ public NativeBlobModuleSpec(ReactApplicationContext reactContext) {
   public abstract void addNetworkingHandler();
 
   @ReactMethod
-  public abstract void createFromParts(ReadableArray parts, String withId);
+  public abstract void addWebSocketHandler(double id);
 
   @ReactMethod
-  public abstract void addWebSocketHandler(double id);
+  public abstract void createFromParts(ReadableArray parts, String withId);
 
   @ReactMethod
   public abstract void release(String blobId);

diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeDevSettingsSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeDevSettingsSpec.java
@@ -31,10 +31,10 @@ public void onFastRefresh() {
   }
 
   @ReactMethod
-  public abstract void removeListeners(double count);
+  public abstract void reload();
 
   @ReactMethod
-  public abstract void reload();
+  public abstract void removeListeners(double count);
 
   @ReactMethod
   public abstract void setProfilingEnabled(boolean isProfilingEnabled);
@@ -43,18 +43,18 @@ public void onFastRefresh() {
   public abstract void addMenuItem(String title);
 
   @ReactMethod
-  public abstract void toggleElementInspector();
+  public abstract void setHotLoadingEnabled(boolean isHotLoadingEnabled);
 
   @ReactMethod
-  public abstract void setHotLoadingEnabled(boolean isHotLoadingEnabled);
+  public abstract void toggleElementInspector();
 
   @ReactMethod
   public void reloadWithReason(String reason) {
   }
 
   @ReactMethod
-  public abstract void setIsShakeToShowDevMenuEnabled(boolean enabled);
+  public abstract void addListener(String eventName);
 
   @ReactMethod
-  public abstract void addListener(String eventName);
+  public abstract void setIsShakeToShowDevMenuEnabled(boolean enabled);
 }
diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeExceptionsManagerSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeExceptionsManagerSpec.java
@@ -30,15 +30,15 @@ public void dismissRedbox() {
   }
 
   @ReactMethod
-  public abstract void updateExceptionMessage(String message, ReadableArray stack,
+  public abstract void reportFatalException(String message, ReadableArray stack,
       double exceptionId);
 
   @ReactMethod
   public void reportException(ReadableMap data) {
   }
 
   @ReactMethod
-  public abstract void reportFatalException(String message, ReadableArray stack,
+  public abstract void updateExceptionMessage(String message, ReadableArray stack,
       double exceptionId);
 
   @ReactMethod

diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImageLoaderAndroidSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImageLoaderAndroidSpec.java
@@ -27,10 +27,10 @@ public NativeImageLoaderAndroidSpec(ReactApplicationContext reactContext) {
   }
 
   @ReactMethod
-  public abstract void getSize(String uri, Promise promise);
+  public abstract void abortRequest(double requestId);
 
   @ReactMethod
-  public abstract void abortRequest(double requestId);
+  public abstract void getSize(String uri, Promise promise);
 
   @ReactMethod
   public abstract void prefetchImage(String uri, double requestId, Promise promise);

diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImagePickerIOSSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImagePickerIOSSpec.java
@@ -30,11 +30,11 @@ public abstract void openCameraDialog(ReadableMap config, Callback successCallba
       Callback cancelCallback);
 
   @ReactMethod
-  public abstract void openSelectDialog(ReadableMap config, Callback successCallback,
-      Callback cancelCallback);
+  public abstract void canUseCamera(Callback callback);
 
   @ReactMethod
-  public abstract void canUseCamera(Callback callback);
+  public abstract void openSelectDialog(ReadableMap config, Callback successCallback,
+      Callback cancelCallback);
 
   @ReactMethod
   public abstract void canRecordVideos(Callback callback);

diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeLinkingSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeLinkingSpec.java
@@ -26,10 +26,10 @@ public NativeLinkingSpec(ReactApplicationContext reactContext) {
   }
 
   @ReactMethod
-  public abstract void sendIntent(String action, ReadableArray extras, Promise promise);
+  public abstract void openURL(String url, Promise promise);
 
   @ReactMethod
-  public abstract void openURL(String url, Promise promise);
+  public abstract void sendIntent(String action, ReadableArray extras, Promise promise);
 
   @ReactMethod
   public abstract void removeListeners(double count);

diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativePermissionsAndroidSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativePermissionsAndroidSpec.java
@@ -26,10 +26,10 @@ public NativePermissionsAndroidSpec(ReactApplicationContext reactContext) {
   }
 
   @ReactMethod
-  public abstract void requestPermission(String permission, Promise promise);
+  public abstract void checkPermission(String permission, Promise promise);
 
   @ReactMethod
-  public abstract void checkPermission(String permission, Promise promise);
+  public abstract void requestPermission(String permission, Promise promise);
 
   @ReactMethod
   public abstract void shouldShowRequestPermissionRationale(String permission, Promise promise);

diff --git a/...ndroid/src/main/java/com/facebook/fbreact/specs/NativePushNotificationManagerIOSSpec.java b/...ndroid/src/main/java/com/facebook/fbreact/specs/NativePushNotificationManagerIOSSpec.java
@@ -28,10 +28,10 @@ public NativePushNotificationManagerIOSSpec(ReactApplicationContext reactContext
   }
 
   @ReactMethod
-  public abstract void removeListeners(double count);
+  public abstract void getInitialNotification(Promise promise);
 
   @ReactMethod
-  public abstract void getInitialNotification(Promise promise);
+  public abstract void removeListeners(double count);
 
   @ReactMethod
   public abstract void setApplicationIconBadgeNumber(double num);
@@ -40,41 +40,41 @@ public NativePushNotificationManagerIOSSpec(ReactApplicationContext reactContext
   public abstract void scheduleLocalNotification(ReadableMap notification);
 
   @ReactMethod
-  public abstract void getScheduledLocalNotifications(Callback callback);
+  public abstract void requestPermissions(ReadableMap permission, Promise promise);
 
   @ReactMethod
   public abstract void checkPermissions(Callback callback);
 
   @ReactMethod
-  public abstract void requestPermissions(ReadableMap permission, Promise promise);
+  public abstract void getScheduledLocalNotifications(Callback callback);
 
   @ReactMethod
   public abstract void removeAllDeliveredNotifications();
 
   @ReactMethod
   public abstract void onFinishRemoteNotification(String notificationId, String fetchResult);
 
-  @ReactMethod
-  public abstract void cancelLocalNotifications(ReadableMap userInfo);
-
   @ReactMethod
   public abstract void abandonPermissions();
 
   @ReactMethod
-  public abstract void removeDeliveredNotifications(ReadableArray identifiers);
+  public abstract void cancelLocalNotifications(ReadableMap userInfo);
 
   @ReactMethod
   public abstract void cancelAllLocalNotifications();
 
+  @ReactMethod
+  public abstract void removeDeliveredNotifications(ReadableArray identifiers);
+
   @ReactMethod
   public abstract void getDeliveredNotifications(Callback callback);
 
   @ReactMethod
   public abstract void getApplicationIconBadgeNumber(Callback callback);
 
   @ReactMethod
-  public abstract void addListener(String eventType);
+  public abstract void presentLocalNotification(ReadableMap notification);
 
   @ReactMethod
-  public abstract void presentLocalNotification(ReadableMap notification);
+  public abstract void addListener(String eventType);
 }
diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeToastAndroidSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeToastAndroidSpec.java
@@ -30,11 +30,11 @@ public NativeToastAndroidSpec(ReactApplicationContext reactContext) {
   }
 
   @ReactMethod
-  public abstract void showWithGravityAndOffset(String message, double duration, double gravity,
-      double xOffset, double yOffset);
+  public abstract void show(String message, double duration);
 
   @ReactMethod
-  public abstract void show(String message, double duration);
+  public abstract void showWithGravityAndOffset(String message, double duration, double gravity,
+      double xOffset, double yOffset);
 
   @ReactMethod
   public abstract void showWithGravity(String message, double duration, double gravity);