Fabric: New props treatment in core module

Summary: Same as previous one. Adopting template-generated `convertRawProp` and `debugStringConvertibleItem` functions in `core` module. Note, to do so we have to change signatures of some conversions functions to make them more overloading-friendly. Reviewed By: fkgozali Differential Revision: D7958243 fbshipit-source-id: 500ee420d9aa562ee3c5810ef625e06541eda8fb
facebook · May 14, 2018 · 120dcec · 120dcec
1 parent c19649c
commit 120dcec
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 23 deletions.
diff --git a/ReactCommon/fabric/attributedstring/ParagraphAttributes.cpp b/ReactCommon/fabric/attributedstring/ParagraphAttributes.cpp
@@ -8,6 +8,7 @@
 #include "ParagraphAttributes.h"
 
 #include <fabric/attributedstring/conversions.h>
+#include <fabric/graphics/conversions.h>
 #include <fabric/debug/debugStringConvertibleUtils.h>
 
 namespace facebook {

diff --git a/ReactCommon/fabric/attributedstring/TextAttributes.cpp b/ReactCommon/fabric/attributedstring/TextAttributes.cpp
@@ -8,8 +8,10 @@
 #include "TextAttributes.h"
 
 #include <fabric/attributedstring/conversions.h>
+#include <fabric/core/conversions.h>
 #include <fabric/graphics/conversions.h>
-#include <fabric/core/debugStringConvertibleUtils.h>
+
+#include <fabric/debug/debugStringConvertibleUtils.h>
 
 namespace facebook {
 namespace react {

diff --git a/...ric/core/layout/layoutValuesConversions.h → ReactCommon/fabric/core/conversions.h b/...ric/core/layout/layoutValuesConversions.h → ReactCommon/fabric/core/conversions.h
@@ -12,15 +12,15 @@
 namespace facebook {
 namespace react {
 
-inline std::string stringFromLayoutDirection(const LayoutDirection &layoutDirection) {
+inline std::string toString(const LayoutDirection &layoutDirection) {
   switch (layoutDirection) {
     case LayoutDirection::Undefined: return "undefined";
     case LayoutDirection::LeftToRight: return "ltr";
     case LayoutDirection::RightToLeft: return "rtl";
   }
 }
 
-inline std::string stringFromDisplayType(const DisplayType &displayType) {
+inline std::string toString(const DisplayType &displayType) {
   switch (displayType) {
     case DisplayType::None: return "none";
     case DisplayType::Flex: return "flex";

diff --git a/ReactCommon/fabric/core/debugStringConvertibleUtils.h b/ReactCommon/fabric/core/debugStringConvertibleUtils.h
diff --git a/...fabric/core/shadownode/propsConversions.h → ReactCommon/fabric/core/propsConversions.h b/...fabric/core/shadownode/propsConversions.h → ReactCommon/fabric/core/propsConversions.h