Skip to content

Commit

Permalink
Back out "Expose preprocessor flag for fuseboxEnabledDebug"
Browse files Browse the repository at this point in the history
Summary:
Reverting. The behaviour of [`exported_preprocessor_flags`](https://buck.build/rule/cxx_library.html#:~:text=in%20platform_preprocessor_flags.-,exported_preprocessor_flags,-(defaults%20to%20%5B%5D) was misunderstood (applies this flag).

Changelog: [Internal]

bypass-github-export-checks

Reviewed By: hoxyq

Differential Revision: D59058502

fbshipit-source-id: bf05fbfb3cf865ae6501545561952742ebd0a122
  • Loading branch information
huntie authored and facebook-github-bot committed Jun 26, 2024
1 parent e6dd44d commit 0fb6110
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ InspectorFlags& InspectorFlags::getInstance() {
}

bool InspectorFlags::getFuseboxEnabled() const {
return loadFlagsAndAssertUnchanged().fuseboxEnabled;
return loadFlagsAndAssertUnchanged().fuseboxEnabledDebug;
}

void InspectorFlags::dangerouslyResetFlags() {
Expand All @@ -28,15 +28,11 @@ void InspectorFlags::dangerouslyResetFlags() {
const InspectorFlags::Values& InspectorFlags::loadFlagsAndAssertUnchanged()
const {
InspectorFlags::Values newValues = {
.fuseboxEnabled =
.fuseboxEnabledDebug =
#ifdef REACT_NATIVE_FORCE_ENABLE_FUSEBOX
true,
#elif defined(HERMES_ENABLE_DEBUGGER)
#ifdef REACT_NATIVE_ENABLE_FUSEBOX_DEBUG
true,
#else
ReactNativeFeatureFlags::fuseboxEnabledDebug(),
#endif
#else
ReactNativeFeatureFlags::fuseboxEnabledRelease(),
#endif
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class InspectorFlags {

private:
struct Values {
bool fuseboxEnabled;
bool fuseboxEnabledDebug;
bool operator==(const Values&) const = default;
};

Expand Down

0 comments on commit 0fb6110

Please sign in to comment.