Skip to content

Commit

Permalink
-[UIView _DEBUG_reactShadowView] was removed
Browse files Browse the repository at this point in the history
Summary:
Nobody uses it.
If the reference to the bridge is available (which is should be case for testing purposes at least), it is easy to get same information.

Reviewed By: mmmulani

Differential Revision: D6596376

fbshipit-source-id: 066eeb1e9465b4e0cc9d9b5b6bf41722450870e4
  • Loading branch information
shergin authored and facebook-github-bot committed Dec 20, 2017
1 parent c79246d commit 0ae4c47
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 29 deletions.
4 changes: 0 additions & 4 deletions React/Modules/RCTUIManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -976,10 +976,6 @@ - (void)_manageChildren:(NSNumber *)containerTag
if (view) {
[componentData setProps:props forView:view];
uiManager->_viewRegistry[reactTag] = view;

#if RCT_DEV
[view _DEBUG_setReactShadowView:shadowView];
#endif
}
});

Expand Down
10 changes: 0 additions & 10 deletions React/Views/UIView+React.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,4 @@
*/
@property (nonatomic, readonly) UIView *reactAccessibilityElement;

#if RCT_DEV

/**
Tools for debugging
*/

@property (nonatomic, strong, setter=_DEBUG_setReactShadowView:) RCTShadowView *_DEBUG_reactShadowView;

#endif

@end
15 changes: 0 additions & 15 deletions React/Views/UIView+React.m
Original file line number Diff line number Diff line change
Expand Up @@ -37,21 +37,6 @@ - (void)setNativeID:(NSNumber *)nativeID
objc_setAssociatedObject(self, @selector(nativeID), nativeID, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
}

#if RCT_DEV

- (RCTShadowView *)_DEBUG_reactShadowView
{
return objc_getAssociatedObject(self, _cmd);
}

- (void)_DEBUG_setReactShadowView:(RCTShadowView *)shadowView
{
// Use assign to avoid keeping the shadowView alive it if no longer exists
objc_setAssociatedObject(self, @selector(_DEBUG_reactShadowView), shadowView, OBJC_ASSOCIATION_ASSIGN);
}

#endif

- (BOOL)isReactRootView
{
return RCTIsReactRootView(self.reactTag);
Expand Down

0 comments on commit 0ae4c47

Please sign in to comment.