Make image to work

Summary: ImageManager is used to update the LocalData of Image views, as part of this process we call ImageManager::requestImage in cross platform code. Event if Android doesn't use ImageRequest we need to return an empty non-operation version of this object. Reviewed By: shergin Differential Revision: D10429663 fbshipit-source-id: 3621ece72f7291e2e6ab6a84b238ac16b595fc18
facebook · Oct 22, 2018 · 0984196 · 0984196
1 parent 6debfdf
commit 0984196
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/ReactCommon/fabric/imagemanager/ImageRequest.h b/ReactCommon/fabric/imagemanager/ImageRequest.h
@@ -33,6 +33,8 @@ class ImageRequest final {
    */
   class ImageNoLongerNeededException;
 
+  ImageRequest();
+
   /*
    * `ImageRequest` is constructed with `ImageSource` and
    * `ImageResponse` future which must be moved in inside the object.

diff --git a/ReactCommon/fabric/imagemanager/platform/android/ImageManager.cpp b/ReactCommon/fabric/imagemanager/platform/android/ImageManager.cpp
@@ -20,7 +20,7 @@ ImageManager::~ImageManager() {
 
 ImageRequest ImageManager::requestImage(const ImageSource &imageSource) const {
   // Not implemented.
-  abort();
+  return {};
 }
 
 } // namespace react

diff --git a/ReactCommon/fabric/imagemanager/platform/android/ImageRequest.cpp b/ReactCommon/fabric/imagemanager/platform/android/ImageRequest.cpp
@@ -10,6 +10,8 @@
 namespace facebook {
 namespace react {
 
+ImageRequest::ImageRequest() {}
+
 ImageRequest::ImageRequest(
     const ImageSource &imageSource,
     folly::Future<ImageResponse> &&responseFuture) {