Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doc for emulateUnlessSupported #2919

Conversation

ken0nek
Copy link
Contributor

@ken0nek ken0nek commented Jan 8, 2022

@netlify
Copy link

netlify bot commented Jan 8, 2022

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: a27b4f4

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/61d923c4f1e4d1000852106c

😎 Browse the preview: https://deploy-preview-2919--react-native.netlify.app

@Simek Simek added 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged Wait on future Release This indicates a PR that updates the doc to match a future release. labels Jan 8, 2022
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request May 16, 2022
Summary:
We don't have to check or emulate the safe area for iOS 11 above. I deleted the unnecessary check for the safe area.

This is a continuation pull request of these iOS 11 availability check.
* [Remove iOS 11 version check by ken0nek · Pull Request #32151 · facebook/react-native](#32151)
* [Remove iOS 11 availability check by ken0nek · Pull Request #32488 · facebook/react-native](#32488)

-----

- Stop using layout guide (`topLayoutGuide`, `bottomLayoutGuide`)
- Refactor `RCTSafeAreaView`
- Delete `emulateUnlessSupported` property

Docs PR: facebook/react-native-website#2919

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[iOS] [Removed] - Remove `emulateUnlessSupported`

Pull Request resolved: #32851

Reviewed By: philIip, sammy-SC

Differential Revision: D33586023

Pulled By: cortinico

fbshipit-source-id: 75fc1037141f71d9340c7b875a6bf86f9cfd6a02
@ken0nek
Copy link
Contributor Author

ken0nek commented May 16, 2022

@Simek FYI: facebook/react-native#32851 is merged into main (not published yet).

@Simek Simek removed the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label May 16, 2022
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the 0.69 was shipped and docs for it has been cut, we can merge this in. 🙂

LGTM, thank you for the docs PR @ken0nek! 🙏

@Simek Simek removed the Wait on future Release This indicates a PR that updates the doc to match a future release. label Jun 23, 2022
@Simek Simek merged commit 731493a into facebook:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants