Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Placeholder -> Suspense #1182

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Placeholder -> Suspense #1182

merged 1 commit into from
Oct 17, 2018

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Oct 10, 2018

@gaearon gaearon mentioned this pull request Oct 10, 2018
Merged
@gaearon
Copy link
Contributor Author

gaearon commented Oct 10, 2018

Will release today in the evening unless somebody does it first

@bvaughn
Copy link
Contributor

bvaughn commented Oct 12, 2018

Any reason not to go ahead and merge this (regardless of when the release goes out)?

@gaearon
Copy link
Contributor Author

gaearon commented Oct 12, 2018

Not really, except I haven't had time to test it yet.

@bvaughn
Copy link
Contributor

bvaughn commented Oct 12, 2018

Fastest response time ever?

😄 Fair enough though. Looks solid to me.

@gaearon
Copy link
Contributor Author

gaearon commented Oct 12, 2018

If you want to test and release I wouldn't mind. :P But it's fine if not too.

@bvaughn
Copy link
Contributor

bvaughn commented Oct 12, 2018 •
edited
Loading

Nah, I'm just GitHub lurking in between activities 😄My Internet in China is too sketchy to do much.

@gaearon gaearon merged commit 05b7bd4 into master Oct 17, 2018
@gaearon gaearon deleted the sspns branch October 17, 2018 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @bvaughn @sebmarkbage @facebook-github-bot