Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

refactor: extract has and warning #261

Merged
merged 1 commit into from
Mar 3, 2019
Merged

refactor: extract has and warning #261

merged 1 commit into from
Mar 3, 2019

Conversation

noscripter
Copy link
Contributor

@noscripter noscripter commented Feb 27, 2019 •
edited
Loading

According to DRY, extract has and warning message to lib as well as making the failing tests pass.

ljharb
ljharb suggested changes Feb 28, 2019
View reviewed changes
checkPropTypes.js Outdated Show resolved Hide resolved
checkPropTypes.js Outdated Show resolved Hide resolved
factoryWithTypeCheckers.js Outdated Show resolved Hide resolved
checkPropTypes.js Outdated Show resolved Hide resolved
checkPropTypes.js Outdated Show resolved Hide resolved
__tests__/PropTypesDevelopmentStandalone-test.js Outdated Show resolved Hide resolved
ljharb
ljharb reviewed Feb 28, 2019
View reviewed changes
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR might need to be rebased.

__tests__/PropTypesDevelopmentStandalone-test.js Outdated Show resolved Hide resolved
@ljharb ljharb merged commit e32c490 into facebook:master Mar 3, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 3, 2023
Open
@BuloZB BuloZB mentioned this pull request May 20, 2024
Open
@MarwanShehata MarwanShehata mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@mjperrins mjperrins mentioned this pull request May 25, 2024
Open
@jeremyjohns10 jeremyjohns10 mentioned this pull request May 28, 2024
Closed
@Artur-data-DEV Artur-data-DEV mentioned this pull request Jun 4, 2024
Open
This was referenced Jun 18, 2024
Open
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 3, 2024
Open
@mjperrins mjperrins mentioned this pull request Jul 17, 2024
Open
This was referenced Jul 19, 2024
Open
Open
@mjperrins mjperrins mentioned this pull request Jul 23, 2024
Open
@A2booky A2booky mentioned this pull request Aug 6, 2024
Open
This was referenced Aug 9, 2024
Open
Open
@udilbar udilbar mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Open
@mjperrins mjperrins mentioned this pull request Sep 13, 2024
Open
@Security-Test-Account Security-Test-Account mentioned this pull request Sep 13, 2024
Open
@udilbar udilbar mentioned this pull request Sep 13, 2024
Open
@MarwanShehata MarwanShehata mentioned this pull request Sep 13, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Sep 13, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 13, 2024
Open
@mjperrins mjperrins mentioned this pull request Sep 14, 2024
Open
@yogendrajs yogendrajs mentioned this pull request Sep 14, 2024
Open
@udilbar udilbar mentioned this pull request Sep 14, 2024
Open
@MarwanShehata MarwanShehata mentioned this pull request Sep 14, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Sep 14, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 14, 2024
Open
@udilbar udilbar mentioned this pull request Sep 15, 2024
Open
This was referenced Sep 15, 2024
Open
Open
@mjperrins mjperrins mentioned this pull request Sep 17, 2024
Open
@yogendrajs yogendrajs mentioned this pull request Sep 17, 2024
Open
@Karol-Sobolewski Karol-Sobolewski mentioned this pull request Sep 17, 2024
Open
@MarwanShehata MarwanShehata mentioned this pull request Sep 17, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Sep 17, 2024
Open
@udilbar udilbar mentioned this pull request Sep 18, 2024
Open
@Karol-Sobolewski Karol-Sobolewski mentioned this pull request Sep 18, 2024
Open
@MarwanShehata MarwanShehata mentioned this pull request Sep 18, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Sep 18, 2024
Open
@mjperrins mjperrins mentioned this pull request Sep 19, 2024
Open
@Security-Test-Account Security-Test-Account mentioned this pull request Sep 19, 2024
Open
@yogendrajs yogendrajs mentioned this pull request Sep 19, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Sep 19, 2024
Open
@MarwanShehata MarwanShehata mentioned this pull request Sep 19, 2024
Open
@mjperrins mjperrins mentioned this pull request Sep 20, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noscripter @ljharb @facebook-github-bot