-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix haste module resolution inside of scoped modules (Fixes #241) #249
Conversation
Figured out the win32 problem. This requires a fix to Once it is merged and a version of |
dgraph, | ||
'C:\\root\\index.js', | ||
); | ||
console.error(deps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you remove the console.error()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, forgot that debug line there! Fixed it up.
Wow thanks a lot for the PR 😍 Codewise LGTM, can you run |
Prettified, and cleaned up the debug line |
So because There is a way to go for fixing windows support in the meantime, but I'd like your input @rafeca before I push it to this PR. If I include the patched version of Example: static _createHaste(opts: Options): JestHasteMap {
const hasteMap = new JestHasteMap({
// ... trimed ...
});
hasteMap._whiteList = getWhiteList(opts.providesModuleNodeModules);
return hasteMap;
} An issue would then have to be created to remind to remove this patch when |
I'd prefer to avoid patching I think I can convince @mjesun to publish a new version of |
Skipped the test for now, and CI looks good now! 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!! Thanks a lot for this PR 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rafeca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary
This (WIP!) pull request attempts to fix issues with Haste and scoped modules.
It is a WIP, because I was able to figure out how to get it working on Posix - but I still need to work out what the issue is on Win32.
Test plan
Test cases for posix and win32 have been added to
traverseDependencies-integration-test.js
.