Upgrade Babel to 7.0.0-beta.56 #216
Conversation
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 134 134
Lines 4389 4389
Branches 681 681
=======================================
Hits 3747 3747
Misses 571 571
Partials 71 71
Continue to review full report at Codecov.
|
|
Cool! Thanks for the contribution! Can you add the Also, I'm going to let @pvdz take a look at this one, since he's the Babel guy in Metro 😄 |
Good thinking 👍 I added a default interface export to the file, and verified that it indeed doesn't work on current master. |
|
Thanks! I've just talked to @pvdz and upgrading babel for us internally can potentially be complex (depending on whether there are some subtle breaking changes between beta54 and beta56 that forces us to update some of our internal babel plugins...). I'm going to import this PR and check if it causes any internal issues and report back |
There was a problem hiding this comment.
rafeca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
We’ve found some changes in the generated sourcemaps (caused by babel/babel#8380). The changes seem to be good but we’ve needed some time to verify things. I expect to be able to merge this soon 😃 |
|
|
Summary:
**Summary**
This pull request bumps Babel to 7.0.0-beta.56 to incorporate the latest bugfixes from Babel.
**Test plan**
One way to test is to add a simple TypeScript file with a type as the default export:
```typescript
export const test = 1
export default interface A {}
```
and then import that file from any other file:
```js
import { test } from './typescript-test'
```
Before this would throw an error, but with the latest Babel this is now fixed.
Pull Request resolved: #216
Reviewed By: mjesun
Differential Revision: D9216331
Pulled By: rafeca
fbshipit-source-id: a48e87c3c6b2902be410395b1b4afab63cb88fec
Summary:
**Summary**
This pull request bumps Babel to 7.0.0-beta.56 to incorporate the latest bugfixes from Babel.
**Test plan**
One way to test is to add a simple TypeScript file with a type as the default export:
```typescript
export const test = 1
export default interface A {}
```
and then import that file from any other file:
```js
import { test } from './typescript-test'
```
Before this would throw an error, but with the latest Babel this is now fixed.
Pull Request resolved: facebook/metro#216
Reviewed By: mjesun
Differential Revision: D9216331
Pulled By: rafeca
fbshipit-source-id: a48e87c3c6b2902be410395b1b4afab63cb88fec
|
Thanks for landing this! ❤️ |
|
@LinusU today they released v7.0.0-rc.1 😄 |
|
Haha, yeah I just saw that 😄 |
Summary:
**Summary**
This pull request bumps Babel to 7.0.0-beta.56 to incorporate the latest bugfixes from Babel.
**Test plan**
One way to test is to add a simple TypeScript file with a type as the default export:
```typescript
export const test = 1
export default interface A {}
```
and then import that file from any other file:
```js
import { test } from './typescript-test'
```
Before this would throw an error, but with the latest Babel this is now fixed.
Pull Request resolved: facebook/metro#216
Reviewed By: mjesun
Differential Revision: D9216331
Pulled By: rafeca
fbshipit-source-id: a48e87c3c6b2902be410395b1b4afab63cb88fec
Summary
This pull request bumps Babel to 7.0.0-beta.56 to incorporate the latest bugfixes from Babel.
Test plan
One way to test is to add a simple TypeScript file with a type as the default export:
and then import that file from any other file:
Before this would throw an error, but with the latest Babel this is now fixed.